Review Request 111044: Implement borders for shapes
Commit Hook
null at kde.org
Fri Aug 2 07:39:35 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111044/
-----------------------------------------------------------
(Updated Aug. 2, 2013, 6:39 a.m.)
Status
------
This change has been marked as submitted.
Review request for Calligra, C. Boemann, Boudewijn Rempt, and Thorsten Zachmann.
Description
-------
This patch implements loading, saving and painting of borders for shapes in general. It also implements calls to actually paint borders in particular for the picture shape and text shape.
At the same time I moved border painting from KWCanvasBase to KoBorder, which I announced some weeks ago that I wanted to do.
A patch this deep in the libraries should not go in without a run of cstester. I would be glad for help with this since I only have a semi-weak laptop.
Diffs
-----
libs/flake/KoShape.h fe6cc3f
libs/flake/KoShape.cpp 6d14a8c
libs/flake/KoShape_p.h aa6633c
libs/odf/KoBorder.h bdbf86e
libs/odf/KoBorder.cpp 58f8e45
libs/textlayout/FloatingAnchorStrategy.h eb0ff6b
libs/textlayout/FloatingAnchorStrategy.cpp 465f149
libs/textlayout/KoTextDocumentLayout.cpp 70f4ccd
libs/textlayout/KoTextLayoutRootAreaProvider.h d8c7ac3
libs/textlayout/KoTextShapeData.cpp 1b424b7
plugins/pictureshape/PictureShape.cpp 976fadd
plugins/textshape/SimpleRootAreaProvider.h 62534a6
plugins/textshape/SimpleRootAreaProvider.cpp 63f1898
plugins/textshape/TextShape.cpp b230f0a
words/part/KWCanvasBase.cpp 7d12890
words/part/KWRootAreaProvider.h 45b4870
words/part/KWRootAreaProvider.cpp fc8660d
Diff: http://git.reviewboard.kde.org/r/111044/diff/
Testing
-------
Tested with all the files with the string "border" in it in the test suite.
Thanks,
Inge Wallin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130802/696d07ab/attachment.htm>
More information about the calligra-devel
mailing list