Review Request 110087: Make the use of Rendering Intents consistent
Dmitry Kazakov
dimula73 at gmail.com
Fri Apr 19 16:33:35 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110087/
-----------------------------------------------------------
Review request for Calligra and Cyrille Berger Skott.
Description
-------
This patch make the use of internal rendering intents and conversion flags consistent. Now there are four constants, which should be used throughout all the code:
KoColorConversionTransformation::InternalRenderingIntent
KoColorConversionTransformation::InternalConversionFlags
KoColorConversionTransformation::AdjustmentRenderingIntent
KoColorConversionTransformation::AdjustmentConversionFlags
The latter two are used in the adjustment transformations. They disable white point workaround in lcms to ensure the Brightness/Contrast and friends transformations work fine.
This fixes bug: https://bugs.kde.org/show_bug.cgi?id=318434
Diffs
-----
krita/image/kis_cross_device_color_picker.h eb59305
krita/image/kis_fixed_paint_device.h ede6c13
krita/image/kis_fixed_paint_device.cpp 5f98352
krita/image/kis_group_layer.cc af12663
krita/image/kis_image.cc 73c0cfb
krita/image/kis_layer.cc 6722b3e
krita/image/kis_mask.cc f17fe01
krita/image/kis_paint_device.h 9d68a29
krita/image/kis_paint_device.cc 8c0cdd5
krita/image/kis_painter.cc 5849749
krita/image/kis_selection_based_layer.cpp 4888c0c
krita/image/tests/kis_colorspace_convert_visitor_test.cpp e5835c9
krita/image/tests/kis_image_test.cpp 040d32f
krita/image/tests/kis_selection_test.cpp 7c6141f
krita/plugins/extensions/dockers/advancedcolorselector/kis_common_colors.cpp 006e0ae
krita/plugins/extensions/dockers/historydocker/KisUndoModel.cpp 0839e17
krita/plugins/filters/fastcolortransfer/fastcolortransfer.cpp 32433e6
krita/plugins/filters/fastcolortransfer/kis_wdg_fastcolortransfer.cpp 417c79e
krita/plugins/filters/phongbumpmap/kis_phong_bumpmap_filter.cpp d5828cd
krita/plugins/formats/bmp/kis_bmp_export.cpp 2d84ee9
krita/plugins/formats/jpeg/kis_jpeg_converter.cc 33ec941
krita/plugins/formats/ppm/kis_ppm_export.cpp 60fcc59
krita/plugins/formats/tiff/kis_tiff_converter.cc 695d9e5
krita/plugins/paintops/libbrush/kis_brush.cpp 0763779
krita/plugins/paintops/libbrush/kis_gbr_brush.cpp 94c754a
krita/plugins/paintops/mypaint/hint.txt e04c4c2
krita/plugins/paintops/mypaint/mypaint_surface.cpp 1fb755a
krita/plugins/tools/tool_transform2/kis_tool_transform.cc a13cb17
krita/ui/kis_bookmarked_filter_configurations_model.cc acbf097
krita/ui/kis_clipboard.cc cb810f3
krita/ui/kis_custom_pattern.cc 9b76e2b
krita/ui/kis_filters_model.cc 9b940ae
krita/ui/kis_mimedata.cpp a2305c0
krita/ui/kis_png_converter.cpp 3379a30
krita/ui/tests/kis_prescaled_projection_test.cpp 882e012
krita/ui/widgets/kis_scratch_pad.cpp 036cd1c
libs/pigment/KoColor.cpp ad7abd9
libs/pigment/KoColorConversionSystem.cpp 9a6dc8f
libs/pigment/KoColorConversionTransformation.h 975575d
libs/pigment/KoColorConversionTransformation.cpp 753bd7f
libs/pigment/KoColorSpace.cpp 1489515
libs/pigment/KoCopyColorConversionTransformation.cpp bc96290
libs/pigment/KoFallBackColorTransformation.cpp c8008f0
libs/pigment/KoScaleColorConversionTransformation.h 347510b
libs/pigment/colorspaces/KoSimpleColorSpace.h 85eeaa6
libs/pigment/colorspaces/KoSimpleColorSpaceEngine.cpp 0566475
plugins/colorengines/lcms2/LcmsColorSpace.h ac88351
plugins/colorengines/lcms2/tests/TestKoCompositeOps.cpp 1dee8af
Diff: http://git.reviewboard.kde.org/r/110087/diff/
Testing
-------
Thanks,
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130419/f5b63010/attachment.htm>
More information about the calligra-devel
mailing list