Review Request 109046: Normalize SIGNAL and SLOT signatures in the top level directory of Plan

Friedrich W. H. Kossebau kossebau at kde.org
Mon Apr 15 19:47:22 BST 2013



> On March 30, 2013, 2:31 p.m., Friedrich W. H. Kossebau wrote:
> >

As intermediate maintainer I am interested to see this patch go in, but please first fix the wrong removal of the constness from pointer type args and upload again for a final review :)


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109046/#review30108
-----------------------------------------------------------


On Feb. 26, 2013, 5:22 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109046/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2013, 5:22 p.m.)
> 
> 
> Review request for Calligra and Dag Andersen.
> 
> 
> Description
> -------
> 
> This is yet another normalize signature patch created by fixsrc.py, this time in Plan.
> 
> According to http://englishbreakfastnetwork.org/krazy/reports/bundled-apps/calligra/plan/index.html there are over 2000 such issues in Plan so I'm only fixing those at the top level so that they can be inspected manually without choking on the sheer amount.
> 
> 
> Diffs
> -----
> 
>   plan/kptviewlistdocker.cpp 2c5ec18 
>   plan/kptviewlistdialog.cpp bd7c805 
>   plan/kptview.cpp fcfa192 
>   plan/kptviewlist.cpp 86a3c93 
>   plan/kpttaskdefaultpanel.cpp ec15644 
>   plan/kptpart.cpp 1657c06 
>   plan/kptschedulesdocker.cpp 3217f77 
>   plan/kptinsertfiledlg.cpp 045bce1 
>   plan/kptmaindocument.cpp b4afbc3 
>   plan/kptbuiltinschedulerplugin.cpp c29ae4c 
> 
> Diff: http://git.reviewboard.kde.org/r/109046/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130415/6a53cff9/attachment.htm>


More information about the calligra-devel mailing list