Review Request 109994: New implementation for handling formulas

[Gopalakrishna Bhat]

> On April 13, 2013, 3:30 p.m., Inge Wallin wrote:
> > libs/odf/KoXmlReader.cpp, line 1791
> > <http://git.reviewboard.kde.org/r/109994/diff/1/?file=138544#file138544line1791>
> >
> >     If this is a real bugfix, it should go into master immediately and not in the branch.

I had this mail posted http://mail.kde.org/pipermail/calligra-devel/2013-March/008677.html but did not get any reply. I went ahead and fixed in my branch but forgot to follow up on this. Anyone with a solution or is this a bug?


> On April 13, 2013, 3:30 p.m., Inge Wallin wrote:
> > plugins/staging/formulashape-2g/FormulaShape.cpp, line 149
> > <http://git.reviewboard.kde.org/r/109994/diff/1/?file=138558#file138558line149>
> >
> >     As a general rule, we don't use spaces inside parenthesis.

That is code from old formulashape. I will fix this.


> On April 13, 2013, 3:30 p.m., Inge Wallin wrote:
> > plugins/staging/formulashape-2g/formulashape2g.desktop, line 2
> > <http://git.reviewboard.kde.org/r/109994/diff/1/?file=138569#file138569line2>
> >
> >     That it's 2nd generation is not relevant for users so "Formula Shape" should be enough"

All references to 2G will be removed and the old formula shape will also be removed before merging


- Gopalakrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109994/#review30989
-----------------------------------------------------------


On April 13, 2013, 3:03 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109994/
> -----------------------------------------------------------
> 
> (Updated April 13, 2013, 3:03 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This new implementation for formulashape uses and improves on qtmmlwidgets that was part of Qt Solutions. The code can be found in plugins-formulashape2g-gopalK branch.
> 
> Currently implemented features are
> 1) Loading of formulas in document.
> 2) Insert of MathML formulas generated from some other tools(viz FireMath plugin for Firefox)
> 3) Editing of existing formulas.
> 
> Features that were there in old version of formulashape but missing now
> 1) Insert of Elements, Symbols (in a very much unusable state)
> 2) Edit formulas with LaTeX syntax (Will be done in coming days)
> 
> I will remove the extra whitespace that exists in the uploaded diff before merging :)
> 
> 
> Diffs
> -----
> 
>   libs/odf/KoXmlReader.cpp b5fe9f8 
>   plugins/staging/formulashape-2g/Messages.sh PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaToolFactory.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaToolFactory.h PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaTool.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaTool.h PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaShapePlugin.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaShapePlugin.h PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaShapeFactory.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaShapeFactory.h PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaShape.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaShape.h PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaPart.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaPart.h PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaDocument.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaDocument.h PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaCursor.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/FormulaCursor.h PRE-CREATION 
>   plugins/staging/formulashape-2g/ChangeFormulaCommand.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/ChangeFormulaCommand.h PRE-CREATION 
>   plugins/staging/formulashape-2g/CMakeLists.txt PRE-CREATION 
>   plugins/staging/formulashape-2g/AlterFormulaCommand.cpp PRE-CREATION 
>   plugins/staging/formulashape-2g/AlterFormulaCommand.h PRE-CREATION 
>   plugins/staging/CMakeLists.txt 754362f 
>   plugins/staging/formulashape-2g/formula_export.h PRE-CREATION 
>   plugins/staging/formulashape-2g/formulashape2g.desktop PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/LGPL_EXCEPTION.txt PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/LICENSE.GPL3 PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/LICENSE.LGPL PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/QtMmlDocument PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/QtMmlWidget PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/README.TXT PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/qtmmlwidget.h PRE-CREATION 
>   plugins/staging/formulashape-2g/qtmmlwidget/qtmmlwidget.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109994/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Snapshot
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/13/formulaShape.png
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130413/91b336e4/attachment.htm>