Review Request 109888: remove dead code from Braindump's DockerManager

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109888/
-----------------------------------------------------------

(Updated April 13, 2013, 11:25 a.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra and Cyrille Berger Skott.


Description
-------

On startup of Braindump there are a few warnings about broken signal/slot connections:
Object::connect: No such signal MainWindow::restoringDone() in /home/koder/Kode/kdegit/Calligra/calligra/braindump/src/import/DockerManager.cpp:145
Object::connect: No such signal MainWindow::beforeHandlingToolBars() in /home/koder/Kode/kdegit/Calligra/calligra/braindump/src/import/DockerManager.cpp:147
Object::connect: No such signal MainWindow::afterHandlingToolBars() in /home/koder/Kode/kdegit/Calligra/calligra/braindump/src/import/DockerManager.cpp:148

Reason for the broken connection with restoringDone() is that Braindump's MainWindow class does not subclass from KoMainWindow (any longer?), so there is no such signal to be expected. Attached patch removes that connection and the related slot restoringDone().

The other two signals have also been with KoMainWindow, but were removed with bd46824cab9eff73c6ff5974c002b11d11faec28 . In any case those two connections seem useless, as well as tagging the two methods moveToolBarsBack()/moveToolBars() as slots. So the attached patch removes also both the connections as well as the slot tags.


Diffs
-----

  braindump/src/import/DockerManager.h 913ccba 
  braindump/src/import/DockerManager.cpp 28495b8 

Diff: http://git.reviewboard.kde.org/r/109888/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130413/0fa705f3/attachment.htm>