Review Request 109980: Load styles into a new, more generic style manager

[Lassi Nieminen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109980/#review30969
-----------------------------------------------------------

Ship it!


Ship It!

- Lassi Nieminen


On April 12, 2013, 5:09 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109980/
> -----------------------------------------------------------
> 
> (Updated April 12, 2013, 5:09 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Here is step 2 in the plan to create a docx export filter.
> 
> It contains code to load styles into a decently generic style manager. The main use of this version will be as a much faster alternative to KoOdfStylesReader that forces you to reparse the XML of all styles that you want to access. This code loads the style content into more easily accessed data structures. The current version only supports the Text, Paragraph, and Graphic families because that's what we need in the docx filter.
> 
> I also have a half-finished patch of Karbon that makes it load, store and save graphics styles which it currently discards in all odg files. However that turned out to be more difficult than expected because the text based style manager in libs/kotext doesn't allow anybody to save any styles outside itself so I'm postponing that into a separate patch. This way we can start using these styles when doing the docx export.
> 
> As a side note, I have also included a new innovative XML stream reader which I will port the odf traverser to.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ff832cc 
>   filters/libodftraverse/OdfTraverserContext.cpp 884e3d4 
>   libs/odf/CMakeLists.txt 3680486 
>   libs/odf/KoXmlStreamReader.h PRE-CREATION 
>   libs/odf/KoXmlStreamReader.cpp PRE-CREATION 
>   libs/odf/styles/KoOdfStyle.h PRE-CREATION 
>   libs/odf/styles/KoOdfStyle.cpp PRE-CREATION 
>   libs/odf/styles/KoOdfStyleManager.h PRE-CREATION 
>   libs/odf/styles/KoOdfStyleManager.cpp PRE-CREATION 
>   libs/odf/styles/KoOdfStyleProperties.h PRE-CREATION 
>   libs/odf/styles/KoOdfStyleProperties.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109980/diff/
> 
> 
> Testing
> -------
> 
> Tested the loading of the styles very thoroughly through manual inspection since this is what's needed for docx export. Not tested saving as thoroughly but will do that when it's used in any real application.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130412/9542785d/attachment.htm>