Review Request 109806: Kexi - By default missing CSV values imported as empty texts.

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109806/#review30532
-----------------------------------------------------------



kexi/doc/dev/settings.txt
<http://git.reviewboard.kde.org/r/109806/#comment22729>

    text( -> text (



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/109806/#comment22730>

    1. Even better would be KexiDB::Field::isTextType(....)
    
    2. Missing check for m_options.nullsImportedAsEmptyTextChecked



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/109806/#comment22944>

    Missing check for m_options.nullsImportedAsEmptyTextChecked



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/109806/#comment22941>

    instead -> otherwise



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<http://git.reviewboard.kde.org/r/109806/#comment22942>

    please remove debug in the final patch



kexi/plugins/importexport/csv/kexicsvimportoptionsdlg.h
<http://git.reviewboard.kde.org/r/109806/#comment22943>

    by the way, let's remove ": 1" in all lines here, it isn't practical approach


- Jarosław Staniek


On March 31, 2013, 1:16 p.m., Tomasz Olszak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109806/
> -----------------------------------------------------------
> 
> (Updated March 31, 2013, 1:16 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> [CSV Import]
> * By default missing CSV text values imported as empty text .
> * Added option which enabled old behavior(missing values imported as NULLs to database)
> 
> 
> This addresses bug 317509.
>     http://bugs.kde.org/show_bug.cgi?id=317509
> 
> 
> Diffs
> -----
> 
>   kexi/doc/dev/settings.txt 7911352 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp fc44bec 
>   kexi/plugins/importexport/csv/kexicsvimportoptionsdlg.h f6a29a1 
>   kexi/plugins/importexport/csv/kexicsvimportoptionsdlg.cpp 18f134c 
> 
> Diff: http://git.reviewboard.kde.org/r/109806/diff/
> 
> 
> Testing
> -------
> 
> Imported csv with mixed integer, text, missing values. Handled and tested case with multiple missing values ("A","B",,,,"C","D")
> 
> 
> Thanks,
> 
> Tomasz Olszak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130410/065f144e/attachment.htm>