Review Request 109894: Fix look of the modern menu and tabbed toolbar for the bespin widget style

Oleg Kukharchuk oleg.kuh at gmail.com
Tue Apr 9 10:00:26 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109894/#review30754
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Kukharchuk


On April 7, 2013, 8:01 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109894/
> -----------------------------------------------------------
> 
> (Updated April 7, 2013, 8:01 p.m.)
> 
> 
> Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.
> 
> 
> Description
> -------
> 
> Fix look of the modern menu and tabbed toolbar for the bespin widget style
> 
> - the menu backgroud set to Shadow color
> - proper selection display for the modern menu
> - proper height for the tabbed toolbar 
> - proper logo variant (black)
> 
> The solution is based on conditions so isn't 100% perfect but bespin pushes the limits of QStyle so this is all what can be done in reasonable time.
> 
> Will be backported to 2.6.4 too.
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMenuWidget_p.h 2793ef6613f42dc92aa4c7dd2c15f388c4f99fb3 
>   kexi/main/KexiMenuWidget.cpp f1d8f79fb1c3496c6da669a94127e346278788d1 
>   kexi/main/KexiMainWindow_p.h 1f5a31ea60f1f78bf0954571453e5002be47b5fe 
> 
> Diff: http://git.reviewboard.kde.org/r/109894/diff/
> 
> 
> Testing
> -------
> 
> Run the relevant UIs with the bespin style. Looks OK.
> 
> 
> File Attachments
> ----------------
> 
> Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/07/bespin1.png
> After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/07/bespin2.png
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130409/0ecfe92b/attachment.htm>


More information about the calligra-devel mailing list