Review Request 109897: Remove any hardcoding of spacing to 6 px and margins to 9/11 px in Krita's UI

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109897/#review30748
-----------------------------------------------------------

Ship it!


Ship It!

- Boudewijn Rempt


On April 7, 2013, 8:32 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109897/
> -----------------------------------------------------------
> 
> (Updated April 7, 2013, 8:32 p.m.)
> 
> 
> Review request for Calligra, Sven Langkamp and Boudewijn Rempt.
> 
> 
> Description
> -------
> 
> This seems a left-over from KDE3/Qt3 times, spacings and margins should be completely controlled by the style IMHO. Only exceptions should be setting the values to 0 to not have any margins/spacings, or if there is some pixel-perfect layouting done.
> 
> 
> Diffs
> -----
> 
>   krita/plugins/extensions/colorrange/wdg_colorrange.ui 37e64c3 
>   krita/plugins/extensions/colorspaceconversion/wdgconvertcolorspace.ui b31861b 
>   krita/plugins/extensions/compose/wdg_compose.ui 91a1788 
>   krita/plugins/extensions/dockers/defaultdockers/wdglayerbox.ui ecfd983 
>   krita/plugins/extensions/dropshadow/wdg_dropshadow.ui f03818a 
>   krita/plugins/extensions/histogram/wdghistogram.ui f80c3c1 
>   krita/plugins/extensions/imagesize/wdg_canvassize.ui 056b545 
>   krita/plugins/extensions/imagesize/wdg_imagesize.ui 2c0a2ab 
>   krita/plugins/extensions/imagesize/wdg_layersize.ui 94e71a2 
>   krita/plugins/extensions/imagesplit/wdg_imagesplit.ui 601f5ab 
>   krita/plugins/extensions/modify_selection/wdg_border_selection.ui 73d983b 
>   krita/plugins/extensions/modify_selection/wdg_feather_selection.ui af505ab 
>   krita/plugins/extensions/modify_selection/wdg_grow_selection.ui 8b3b8c4 
>   krita/plugins/extensions/modify_selection/wdg_shrink_selection.ui 234aab5 
>   krita/plugins/extensions/offsetimage/wdg_offsetimage.ui 2ab32ff 
>   krita/plugins/extensions/rotateimage/wdg_rotateimage.ui e721842 
>   krita/plugins/extensions/separate_channels/wdg_separations.ui 5ed2c89 
>   krita/plugins/extensions/shearimage/wdg_shearimage.ui 4bd9c4d 
>   krita/plugins/filters/blur/wdg_gaussian_blur.ui dc1e594 
>   krita/plugins/filters/blur/wdg_lens_blur.ui 7993830 
>   krita/plugins/filters/blur/wdg_motion_blur.ui 729bc4f 
>   krita/plugins/filters/blur/wdgblur.ui 4b7535c 
>   krita/plugins/filters/colors/wdgcolortoalphabase.ui 2dcc3d4 
>   krita/plugins/filters/colorsfilters/wdg_brightness_contrast.ui f462b7b 
>   krita/plugins/filters/colorsfilters/wdg_perchannel.ui a8872b6 
>   krita/plugins/filters/dodgeburn/DodgeBurnConfigurationBaseWidget.ui 975e1e7 
>   krita/plugins/filters/fastcolortransfer/wdgfastcolortransfer.ui c97eb5b 
>   krita/plugins/filters/levelfilter/wdg_level.ui cda6ffc 
>   krita/plugins/filters/noisefilter/wdgnoiseoptions.ui cdf8b07 
>   krita/plugins/filters/randompickfilter/wdgrandompickoptions.ui 5800237 
>   krita/plugins/filters/unsharp/wdgunsharp.ui 152ef9f 
>   krita/plugins/filters/wavefilter/wdgwaveoptions.ui c70d62e 
>   krita/plugins/formats/pdf/pdfimportwidgetbase.ui 506fd49 
>   krita/plugins/formats/png/kis_wdg_options_png.ui 85f6f57 
>   krita/plugins/formats/raw/wdgrawimport.ui 6a78272 
>   krita/plugins/formats/tiff/kis_wdg_options_tiff.ui f1f7389 
>   krita/plugins/generators/solid/wdgcoloroptions.ui 936def0 
>   krita/plugins/paintops/libpaintop/forms/wdgcustombrush.ui cd6eb34 
>   krita/plugins/tools/defaulttools/kis_tool_measure.cc 223f317 
>   krita/plugins/tools/defaulttools/wdgcolorpicker.ui 7d1c711 
>   krita/plugins/tools/tool_crop/wdg_tool_crop.ui 08bc2ca 
>   krita/plugins/tools/tool_text/wdgtextoptions.ui 5560fc0 
>   krita/ui/dialogs/kis_dlg_adj_layer_props.cc 70a389c 
>   krita/ui/forms/kis_matrix_widget.ui 63c1e97 
>   krita/ui/forms/kis_previewwidgetbase.ui 2faa678 
>   krita/ui/forms/wdg_resolution.ui 1108a6e 
>   krita/ui/forms/wdgapplyprofile.ui 7dd5d71 
>   krita/ui/forms/wdgautogradient.ui 2b157b7 
>   krita/ui/forms/wdgbookmarkedconfigurationseditor.ui 0054dbf 
>   krita/ui/forms/wdgcolorsettings.ui cee3691 
>   krita/ui/forms/wdgcustompalette.ui 65f4ea3 
>   krita/ui/forms/wdgdisplaysettings.ui 8ac25c7 
>   krita/ui/forms/wdgdlgblacklistcleanup.ui c99ccc0 
>   krita/ui/forms/wdgflipbookselector.ui dca0ab7 
>   krita/ui/forms/wdggeneralsettings.ui f4e80c0 
>   krita/ui/forms/wdggridsettings.ui eab3c57 
>   krita/ui/forms/wdgimageproperties.ui 4f1e2a9 
>   krita/ui/forms/wdglayerproperties.ui d952ab7 
>   krita/ui/forms/wdgnewimage.ui a9f1a27 
>   krita/ui/forms/wdgperformancesettings.ui cca6e5f 
>   krita/ui/forms/wdgselectionoptions.ui 19fc539 
>   krita/ui/forms/wdgshapeoptions.ui 65c0e9c 
>   krita/ui/forms/wdgtabletsettings.ui dd0cde5 
> 
> Diff: http://git.reviewboard.kde.org/r/109897/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130409/4fc564f0/attachment.htm>