Review Request 109896: Lot's of margin twisting in Krita brush config UI

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109896/#review30747
-----------------------------------------------------------

Ship it!


Ship It!

- Boudewijn Rempt


On April 7, 2013, 8:45 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109896/
> -----------------------------------------------------------
> 
> (Updated April 7, 2013, 8:45 p.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Description
> -------
> 
> Among other things removed the margin from KoResourceItemChooser, as it is a widget, only composed from other widgets, so to align properly with other widgets there should not be a margin around it.
> 
> 
> Diffs
> -----
> 
>   krita/plugins/paintops/colorsmudge/kis_smudge_option_widget.cpp 6425262 
>   krita/plugins/paintops/defaultpaintops/duplicate/wdgduplicateop.ui de3d971 
>   krita/plugins/paintops/hairy/wdgbristleoptions.ui 0207117 
>   krita/plugins/paintops/libpaintop/forms/wdgBrushSizeOptions.ui 18e9a47 
>   krita/plugins/paintops/libpaintop/forms/wdgCompositeOpOption.ui c2b7774 
>   krita/plugins/paintops/libpaintop/forms/wdgairbrush.ui 25ae7a6 
>   krita/plugins/paintops/libpaintop/forms/wdgautobrush.ui a81be41 
>   krita/plugins/paintops/libpaintop/forms/wdgbrushchooser.ui 159f512 
>   krita/plugins/paintops/libpaintop/forms/wdgcurveoption.ui ca964f3 
>   krita/plugins/paintops/libpaintop/forms/wdgcustombrush.ui cd6eb34 
>   krita/plugins/paintops/libpaintop/forms/wdgfilteroption.ui 64431c7 
>   krita/plugins/paintops/libpaintop/forms/wdgflowopacityoption.ui 1479e0f 
>   krita/plugins/paintops/libpaintop/forms/wdgincremental.ui d6e3f59 
>   krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp 1f7efda 
>   krita/plugins/paintops/libpaintop/kis_brush_selection_widget.cpp 554b3dd 
>   krita/plugins/paintops/libpaintop/kis_color_source_option_widget.cpp e214cde 
>   krita/plugins/paintops/libpaintop/kis_pressure_mirror_option_widget.cpp b4e1e4a 
>   krita/plugins/paintops/libpaintop/kis_pressure_scatter_option_widget.cpp 049bd81 
>   krita/plugins/paintops/libpaintop/kis_pressure_sharpness_option_widget.cpp ed8160f 
>   krita/plugins/paintops/libpaintop/kis_texture_option.cpp b7de392 
>   krita/plugins/paintops/spray/wdgsprayoptions.ui ef5ac44 
>   krita/ui/forms/wdgcustompattern.ui 41358a9 
>   krita/ui/forms/wdgpaintoppresets.ui 7cda562 
>   krita/ui/kis_control_frame.cpp 6b58079 
>   krita/ui/widgets/kis_pattern_chooser.cc 7e8fe65 
>   krita/ui/widgets/kis_workspace_chooser.cpp a221153 
>   libs/widgets/KoResourceItemChooser.cpp 261c09f 
> 
> Diff: http://git.reviewboard.kde.org/r/109896/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130409/b82840c8/attachment.htm>