Review Request 109888: remove dead code from Braindump's DockerManager

[Cyrille Berger Skott]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109888/#review30655
-----------------------------------------------------------

Ship it!


I guess if the signals are not connected, there is no harm in removing the slots, so thanks for the patch and go ahead for the commit.

- Cyrille Berger Skott


On April 6, 2013, 8:33 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109888/
> -----------------------------------------------------------
> 
> (Updated April 6, 2013, 8:33 p.m.)
> 
> 
> Review request for Calligra and Cyrille Berger Skott.
> 
> 
> Description
> -------
> 
> On startup of Braindump there are a few warnings about broken signal/slot connections:
> Object::connect: No such signal MainWindow::restoringDone() in /home/koder/Kode/kdegit/Calligra/calligra/braindump/src/import/DockerManager.cpp:145
> Object::connect: No such signal MainWindow::beforeHandlingToolBars() in /home/koder/Kode/kdegit/Calligra/calligra/braindump/src/import/DockerManager.cpp:147
> Object::connect: No such signal MainWindow::afterHandlingToolBars() in /home/koder/Kode/kdegit/Calligra/calligra/braindump/src/import/DockerManager.cpp:148
> 
> Reason for the broken connection with restoringDone() is that Braindump's MainWindow class does not subclass from KoMainWindow (any longer?), so there is no such signal to be expected. Attached patch removes that connection and the related slot restoringDone().
> 
> The other two signals have also been with KoMainWindow, but were removed with bd46824cab9eff73c6ff5974c002b11d11faec28 . In any case those two connections seem useless, as well as tagging the two methods moveToolBarsBack()/moveToolBars() as slots. So the attached patch removes also both the connections as well as the slot tags.
> 
> 
> Diffs
> -----
> 
>   braindump/src/import/DockerManager.h 913ccba 
>   braindump/src/import/DockerManager.cpp 28495b8 
> 
> Diff: http://git.reviewboard.kde.org/r/109888/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130408/e8e6bdf3/attachment.htm>