Review Request 109889: Postfix all texts of labels before edit fields with a ":" in Krita's brush config UI

Boudewijn Rempt boud at valdyas.org
Sun Apr 7 09:19:33 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109889/#review30596
-----------------------------------------------------------

Ship it!


Ship It!

- Boudewijn Rempt


On April 6, 2013, 10:21 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109889/
> -----------------------------------------------------------
> 
> (Updated April 6, 2013, 10:21 p.m.)
> 
> 
> Review request for Calligra, Sven Langkamp and Boudewijn Rempt.
> 
> 
> Description
> -------
> 
> Found an older unfinished patch which cleans up Krita's brush config UI a little.
> Before it bitrots, here the strings related part:
> It adds a ":" behind all labels which miss one when in front of edit fields. In a few places also fixes capitalization, but that might be subject to discussion.
> 
> Fixes to margin and other layout stuff from that patch need some more brush-up, will arrive only as separate review request.
> 
> 
> Diffs
> -----
> 
>   krita/plugins/paintops/chalk/wdgchalkoptions.ui e05b9d6 
>   krita/plugins/paintops/colorsmudge/kis_smudge_option_widget.cpp 1213ce0 
>   krita/plugins/paintops/curvebrush/wdgcurveoptions.ui fc9eafd 
>   krita/plugins/paintops/deform/wdgdeformoptions.ui 5738ee7 
>   krita/plugins/paintops/dynadraw/wdgdynaoptions.ui 1bc0369 
>   krita/plugins/paintops/experiment/wdgshapeoptions.ui 00ea2ee 
>   krita/plugins/paintops/gridbrush/wdggridoptions.ui b69a1d1 
>   krita/plugins/paintops/hairy/wdgbristleoptions.ui 670d28c 
>   krita/plugins/paintops/libpaintop/forms/wdgBrushSizeOptions.ui 1f331b5 
>   krita/plugins/paintops/libpaintop/forms/wdgairbrush.ui cee9df6 
>   krita/plugins/paintops/libpaintop/forms/wdgcoloroptions.ui a9869f6 
>   krita/plugins/paintops/libpaintop/forms/wdgcustombrush.ui 4ba120c 
>   krita/plugins/paintops/libpaintop/forms/wdgfilteroption.ui 3f864ad 
>   krita/plugins/paintops/libpaintop/forms/wdgflowopacityoption.ui 57e7ac6 
>   krita/plugins/paintops/libpaintop/kis_texture_option.cpp cec1e0e 
>   krita/plugins/paintops/particle/wdgparticleoptions.ui a9a2b17 
>   krita/plugins/paintops/sketch/wdgsketchoptions.ui 0ba85cc 
>   krita/plugins/paintops/spray/wdgshapeoptions.ui 17af8fc 
>   krita/plugins/paintops/spray/wdgsprayoptions.ui 504c494 
>   krita/plugins/tools/selectiontools/kis_tool_select_magnetic_option_widget.ui 6fa2e74 
> 
> Diff: http://git.reviewboard.kde.org/r/109889/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130407/d9baf4c2/attachment.htm>


More information about the calligra-devel mailing list