Review Request 108651: Nicer appearance of image after cropping.

[Albert Astals Cid]

> On Jan. 29, 2013, 8:36 a.m., Dmitry Kazakov wrote:
> > libs/widgets/KoZoomController.h, line 88
> > <http://git.reviewboard.kde.org/r/108651/diff/1/?file=109765#file109765line88>
> >
> >     Probably, some other name without 'set' prefix would be better? One might thing this "setter"-method accepts a value...
> 
> Boudewijn Rempt wrote:
>     Wasn't this already committed?

As far as i can see, no, it was not. Sven are you going to rework this according to Dmitry's suggestions?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108651/#review26349
-----------------------------------------------------------


On Jan. 29, 2013, 7:06 a.m., Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108651/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2013, 7:06 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> As described in bug 313489, the image is currently placed at the wrong area after crop. The patch does three things: reset the transformation, change the zoom mode while keeping the zoom level constant (so there is no fit to page) and pan the canvas. If there was no transformation of the canvas, the result image will be exactly at the position where the crop rect was.
> 
> 
> This addresses bug 313489.
>     http://bugs.kde.org/show_bug.cgi?id=313489
> 
> 
> Diffs
> -----
> 
>   krita/plugins/tools/tool_crop/kis_tool_crop.cc 65c9458 
>   libs/widgets/KoZoomController.h 0ce6d77 
>   libs/widgets/KoZoomController.cpp 4973ef3 
> 
> Diff: http://git.reviewboard.kde.org/r/108651/diff/
> 
> 
> Testing
> -------
> 
> Tested with normal and transformed images.
> 
> 
> Thanks,
> 
> Sven Langkamp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130405/c252819e/attachment.htm>