Review Request: Fix loading partial translation of Sheets scripts, replace KSpread with Sheets in headers of the scripts

Commit Hook null at kde.org
Sat Sep 29 17:27:16 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106306/#review19599
-----------------------------------------------------------


This review has been submitted with commit 4270d49fbb49347f2c6f92170cf81d1f35d26869 by Yuri Chornoivan to branch master.

- Commit Hook


On Sept. 1, 2012, 3:27 p.m., Yuri Chornoivan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106306/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2012, 3:27 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> -------
> 
> Sheets script plugins load translation from krossmodulekspread.po but translation catalog is named as krossmoduletables.pot.
> 
> Most of the scripts contain references to non-existing www.calligra.org/kspread and KSpread window, etc.
> 
> Hope this patch fixes some of these issues.
> 
> 
> Diffs
> -----
> 
>   sheets/plugins/scripting/CMakeLists.txt 9b7f610 
>   sheets/plugins/scripting/Messages.sh 003b418 
>   sheets/plugins/scripting/ScriptingPart.cpp ebcaa09 
>   sheets/plugins/scripting/krossmodulekspread.desktop 739609a 
>   sheets/plugins/scripting/krossmodulesheets.desktop PRE-CREATION 
>   sheets/plugins/scripting/scripting.rc 53622b2 
>   sheets/plugins/scripting/scripts/consoledocker.py 1b10d89 
>   sheets/plugins/scripting/scripts/csvexport.py 38ccc71 
>   sheets/plugins/scripting/scripts/csvimport.py ff15c16 
>   sheets/plugins/scripting/scripts/functions.py a5013c2 
>   sheets/plugins/scripting/scripts/htmlexport.py 63ec950 
>   sheets/plugins/scripting/scripts/kexidbexport.py 30a3f73 
>   sheets/plugins/scripting/scripts/kexidbimport.py 17d2338 
>   sheets/plugins/scripting/scripts/odfpyexport.py d0ac37a 
>   sheets/plugins/scripting/scripts/rpyfunctions.py 199e66b 
>   sheets/plugins/scripting/scripts/vcardimport.py 746b0d9 
>   sheets/plugins/scripting/scripts/xmlviewer.py bfa9a8c 
>   sheets/plugins/scripting/scripts/yfinance.py a5ee11c 
>   sheets/plugins/scripting/scripts/yweather.py 702e6ca 
> 
> Diff: http://git.reviewboard.kde.org/r/106306/diff/
> 
> 
> Testing
> -------
> 
> Tested on current git. Not all translations are loaded due to incomplete localization of scripting module (T = Kross.module("kdetranslation") + T.i18n("message") are not used & some troubles with loading plugin names). But Calligra Sheets menu shows much more translated than before.
> 
> 
> Thanks,
> 
> Yuri Chornoivan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120929/bb0b364b/attachment.htm>


More information about the calligra-devel mailing list