Review Request: changed KoTextBlockData usage
C. Boemann
cbr at boemann.dk
Mon Sep 24 17:27:56 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106559/
-----------------------------------------------------------
Review request for Calligra and Thorsten Zachmann.
Description
-------
I've changed KoTextBlockData from being stored directly in QtextBlock::userData to storing it's private class
The usage of the class has also changed slightly. Now the class stores itself (well it's private class) on the block
KoTextBlockData itself has become a use-and-throw-away class. It takes care of storing itself on the block
Diffs
-----
libs/kotext/KoTextBlockData.h 50baba9
libs/kotext/KoTextBlockData.cpp 9f7062e
libs/kotext/opendocument/KoTextLoader.cpp d8c6908
libs/textlayout/KoTextLayoutArea.h 096e7f1
libs/textlayout/KoTextLayoutArea.cpp 4476f77
libs/textlayout/KoTextLayoutArea_paint.cpp db08f67
libs/textlayout/ListItemsHelper.cpp 0c32981
stage/part/KPrShapeAnimations.cpp 5aec0b9
stage/part/animations/KPrAnimSet.cpp bdbd838
stage/part/animations/KPrAnimateMotion.cpp 5ae90d7
stage/part/animations/KPrAnimationBase.cpp 2afcd29
stage/part/animations/KPrAnimationCache.h ea28d5e
stage/part/animations/KPrAnimationCache.cpp bfe2380
stage/part/animations/KPrAnimationLoader.cpp 6bea7f5
stage/part/animations/KPrShapeAnimation.h 8ce5d5d
stage/part/animations/KPrShapeAnimation.cpp 505768d
stage/part/animations/KPrTextBlockPaintStrategy.h 13a8c22
stage/part/animations/KPrTextBlockPaintStrategy.cpp 3cf8fe6
stage/part/animations/strategy/KPrAnimationValue.h 493242b
stage/part/animations/strategy/KPrAnimationValue.cpp 36670d3
stage/part/animations/strategy/KPrAttributeHeight.cpp 03bcf82
stage/part/animations/strategy/KPrAttributeRotate.cpp f33374a
stage/part/animations/strategy/KPrAttributeWidth.cpp 8b4d07f
stage/part/animations/strategy/KPrAttributeX.cpp b56e4a3
stage/part/animations/strategy/KPrAttributeY.cpp c2a5b6e
stage/part/animations/strategy/KPrFormulaParser.h e0ddb0f
stage/part/animations/strategy/KPrFormulaParser.cpp f12e829
stage/part/tools/animationtool/KPrPredefinedAnimationsLoader.cpp 909e54f
stage/part/tools/animationtool/KPrShapeAnimationDocker.cpp 21624f8
Diff: http://git.reviewboard.kde.org/r/106559/diff/
Testing
-------
So far only basic usage of Words. And I have several other commits that use it so I'm fairly sure the idea works. Have no tried Stage and in particular the new animation stuff
Thanks,
C. Boemann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120924/1a76afec/attachment.htm>
More information about the calligra-devel
mailing list