Review Request: Review for export odt to Mobi

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106486/#review19088
-----------------------------------------------------------


Not bad!  I found no big problem but a number of small ones.  They should be possible to fix pretty quickly. Good work!


filters/words/epub/OdfParser.cpp
<http://git.reviewboard.kde.org/r/106486/#comment15164>

    If these can be disabled then it's better to remove them altogether.



filters/words/epub/OdtHtmlConverter.h
<http://git.reviewboard.kde.org/r/106486/#comment15165>

    The comment is somewhat redundant.  Better explain what the mobi conventions are.



filters/words/epub/OdtHtmlConverter.h
<http://git.reviewboard.kde.org/r/106486/#comment15166>

    indention is not a word.  It should probably be doIndent



filters/words/mobi/MobiFile.cpp
<http://git.reviewboard.kde.org/r/106486/#comment15167>

    You need license information here.



filters/words/mobi/MobiFile.cpp
<http://git.reviewboard.kde.org/r/106486/#comment15168>

    All of these constants could use some explaining if you you know what they are.



filters/words/mobi/MobiHeaderGenerator.cpp
<http://git.reviewboard.kde.org/r/106486/#comment15169>

    Check "man 2 time" :)
    
    (the system call)



filters/words/mobi/PalmDocCompression.cpp
<http://git.reviewboard.kde.org/r/106486/#comment15170>

    should these be consts?



filters/words/mobi/PalmDocCompression.cpp
<http://git.reviewboard.kde.org/r/106486/#comment15171>

    The value 4096 should be a named constant.


- Inge Wallin


On Sept. 17, 2012, 8:58 p.m., mojtaba shahi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106486/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 8:58 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> After calligra Author announced, we had requests to add another filter export to Mobi.
> The Amazon kindles use this format for their ebooks.
> MOBI is the format used by the MobiPocket Reader. It may have a .mobi extension or it may have a .prc extension. The extension can be changed by the user to either of the accepted forms.
> It is a binary file that contains headers include PalmDoc headres and Mobi headers then Text, that is a raw html file, and then images. For Text there are three
> modes: no compression, PalmDoc compression and HUFF/CDIC compression, that i implement the palmDoc compression. For html i use OdtHtmlConverter but i need something special for mobi so i handle my changes in class with a flag. Somethings that are special for mobi is handle img tag that for mobi we dont have any href it use another specific attribute named recindex, and for other changes i didn't need meta or ling elements and there is other one for internal links
> that i haven't implementedit yet.
> 
> you can get more information in http://wiki.mobileread.com/wiki/MOBI#Description
> 
> Tools that i use for This export are Calibre for read and compress the file, MobiPacket creator the windows version (there is no linux version :) )
> That i tryed to follow the MobiPacket creator files structure.
> 
> 
> Diffs
> -----
> 
>   filters/words/CMakeLists.txt 941b150 
>   filters/words/epub/OdfParser.cpp 4a6d670 
>   filters/words/epub/OdtHtmlConverter.h a3e9d33 
>   filters/words/epub/OdtHtmlConverter.cpp 9088546 
>   filters/words/epub/exportepub2.cpp a2daec8 
>   filters/words/epub/exporthtml.cpp a919a7a 
>   filters/words/mobi/CMakeLists.txt PRE-CREATION 
>   filters/words/mobi/MobiFile.h PRE-CREATION 
>   filters/words/mobi/MobiFile.cpp PRE-CREATION 
>   filters/words/mobi/MobiHeaderGenerator.h PRE-CREATION 
>   filters/words/mobi/MobiHeaderGenerator.cpp PRE-CREATION 
>   filters/words/mobi/PalmDocCompression.h PRE-CREATION 
>   filters/words/mobi/PalmDocCompression.cpp PRE-CREATION 
>   filters/words/mobi/exportmobi.h PRE-CREATION 
>   filters/words/mobi/exportmobi.cpp PRE-CREATION 
>   filters/words/mobi/words_Mobi_export.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106486/diff/
> 
> 
> Testing
> -------
> 
> I tested some documents and it was good.
> It is in its first step don't get hard test from it. :)
> 
> 
> Thanks,
> 
> mojtaba shahi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120917/1e161930/attachment.htm>