Review Request: fix bad offset of cursor markers in rulers if document is smaller than canvas (Stage/Flow)

[Friedrich W. H. Kossebau]

> On Sept. 10, 2012, 2:40 p.m., Boudewijn Rempt wrote:
> > Which recent infinite canvas? Shrikrishna hasn't merged his work, as far as I am aware?

At least there is f5cb8e408e1: "Use an infinite canvas for kopageapps".
But perhaps this is unrelated, was a wild guess, I just cannot remember to have seen this bug before around that time.

All I know is that the fix works, for Stage/Flow (and that I have no idea how to fix Krita, due to the API contract breakage).


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106405/#review18798
-----------------------------------------------------------


On Sept. 9, 2012, 5:03 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106405/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2012, 5:03 p.m.)
> 
> 
> Review request for Calligra, Yue Liu and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> Attached patch aligns the code of KoPAView::updateMousePosition(...) with KarbonView::mousePositionChanged(...).
> Seems Words does not have this problem, due to a different canvas behaviour? Did not investigate.
> 
> Krita has the same problem, but the same fix for KisZoomManager::mousePositionChanged(...) does not help, as KisCanvas2::documentOrigin() is out-of-function ATM. See reply to "Need review and testing for 'zoom-pan-testing-kazakov' branch" on mailinglist calligra-devel.
> 
> No idea if a backport is needed, have not tested and this bug may only have appeared with the recent infinite canvas addition.
> Anyone with a 2.5 can confirm the bug?
> 
> 
> Diffs
> -----
> 
>   libs/kopageapp/KoPAView.cpp d88eece 
> 
> Diff: http://git.reviewboard.kde.org/r/106405/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120910/d4b7d5f9/attachment.htm>