Review Request: Force lowercase letters for object ids; fix for not-all-lowercase names

Oleg Kukharchuk oleg.kuh at gmail.com
Mon Sep 10 13:11:24 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106411/#review18794
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Kukharchuk


On Sept. 9, 2012, 11:42 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106411/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2012, 11:42 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> Force lowercase letters for object ids; fix for not-all-lowercase names
> 
> Details:
> *Force lower case letters for object identifiers (except for widget names)
> **This adds consstency and fixes issue with
> **Also fix support for objects renamed to not-all-lowercase in earlier version of Kexi.
> 
> 
> This addresses bug 306523.
>     http://bugs.kde.org/show_bug.cgi?id=306523
> 
> 
> Diffs
> -----
> 
>   kexi/core/kexiproject.cpp 4e0c15963725fbf69955e20c95304cb07024fe01 
>   kexi/kexidb/connection.cpp 1bfaffd9d651be563ac832b8b952f0f5acc88ef0 
>   kexi/kexiutils/identifier.h 045c4bec8c1d6d54018101dce44694e0e15f8ad7 
>   kexi/kexiutils/identifier.cpp 098edfafa283d980d084b37c8f7e84f5f991d171 
>   kexi/main/kexinamewidget.cpp 8110478c6252c3aefbc35974bf0b3e82a015ed39 
>   kexi/main/startup/KexiNewProjectAssistant.cpp ecc1a78525faea767e737207f8aa75ef74291ac8 
>   kexi/widget/navigator/KexiProjectItemDelegate.cpp e0a1c085bdc93defbdc38c77538cd8cf5064a26f 
> 
> Diff: http://git.reviewboard.kde.org/r/106411/diff/
> 
> 
> Testing
> -------
> 
> Tested rename feature and sample db with object renamed to not-all-lowercase in earlier version of Kexi (see the attachment).
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120910/6cd795c3/attachment.htm>


More information about the calligra-devel mailing list