Review Request: fix bad offset of cursor markers in rulers if document is smaller than canvas (Stage/Flow)

Friedrich W. H. Kossebau kossebau at kde.org
Sun Sep 9 18:03:48 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106405/
-----------------------------------------------------------

Review request for Calligra, Yue Liu and Thorsten Zachmann.


Description
-------

Attached patch aligns the code of KoPAView::updateMousePosition(...) with KarbonView::mousePositionChanged(...).
Seems Words does not have this problem, due to a different canvas behaviour? Did not investigate.

Krita has the same problem, but the same fix for KisZoomManager::mousePositionChanged(...) does not help, as KisCanvas2::documentOrigin() is out-of-function ATM. See reply to "Need review and testing for 'zoom-pan-testing-kazakov' branch" on mailinglist calligra-devel.

No idea if a backport is needed, have not tested and this bug may only have appeared with the recent infinite canvas addition.
Anyone with a 2.5 can confirm the bug?


Diffs
-----

  libs/kopageapp/KoPAView.cpp d88eece 

Diff: http://git.reviewboard.kde.org/r/106405/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120909/9556f0dc/attachment.htm>


More information about the calligra-devel mailing list