Review Request: Fix bug 306133

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106327/#review18534
-----------------------------------------------------------

Ship it!


Look good to me. Can you also push to 2.5?

- Boudewijn Rempt


On Sept. 4, 2012, 2:51 p.m., Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106327/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2012, 2:51 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> When resizing a horizontal or vertical line with the tool options calligra apps crash. This fixes that by setting the scaling for width/height to 1 if division by 0 would occur.
> 
> 
> This addresses bug 306133.
>     http://bugs.kde.org/show_bug.cgi?id=306133
> 
> 
> Diffs
> -----
> 
>   plugins/defaultTools/defaulttool/DefaultToolWidget.cpp 6e30c15 
> 
> Diff: http://git.reviewboard.kde.org/r/106327/diff/
> 
> 
> Testing
> -------
> 
> Tested with the document on the bug report to resize horizontal/vertical lines and it works perfectly.
> 
> 
> Thanks,
> 
> Thorsten Zachmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120905/7c15ca0e/attachment.htm>