Review Request: Field list: return bool from removeFiled(), add moveField()

Jarosław Staniek staniek at kde.org
Tue Sep 4 21:31:18 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106330/
-----------------------------------------------------------

Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.


Description
-------

Field list: return bool from removeFiled(), add moveField()

+improve debug

Returning bool helps to check corner cases. moveField() will be used in Table Designer's "Reorder Fields" action.


Diffs
-----

  libs/db/fieldlist.cpp d1cbc6870449a186424e8fe5052df712414473d2 
  libs/db/queryschema.h 522b09511647f5c56056cc12ec7ebf4217724e5b 
  libs/db/queryschema.cpp a992bc408e3c7e9963d5da23422ee8c0abb033cf 
  libs/db/tableschema.h 6c28dbfd511a4e5eedd4d31b74b276bee019840e 
  libs/db/tableschema.cpp 337af574769c93b86ff84343219ffa9e1ffdc097 
  kexi/plugins/scripting/kexidb/kexidbfieldlist.cpp 3037c00f310dcfd0f8d6175f08c6341ce91535ce 
  libs/db/fieldlist.h 2aebbff4b8b98de8ac9ff58ec2e977c5c22e6014 

Diff: http://git.reviewboard.kde.org/r/106330/diff/


Testing
-------

Kexi functions as before.


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120904/cd90a034/attachment.htm>


More information about the calligra-devel mailing list