Review Request: Add Blob Tool to Calligra

[Thorsten Zachmann]

> On Sept. 1, 2012, 4:38 a.m., Thorsten Zachmann wrote:
> > plugins/vectortools/KoBlobToolFactory.cpp, line 33
> > <http://git.reviewboard.kde.org/r/106283/diff/1/?file=82424#file82424line33>
> >
> >     This should be change to
> >     
> >     setToolType(mainToolType());
> >     
> >     as it is a tool that should be shown allways.
> 
> C. Boemann wrote:
>     uhm no please - it's not interesting for words, so if you want it in stage, please add calligrastage, but don't force it on everyone else

I think that is totally unrelated. The tool shows up in stage with the current set. This only gives the group it should be added to if I'm not mistaken. It does not define in which applicaiton is shown or not.


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106283/#review18354
-----------------------------------------------------------


On Aug. 30, 2012, 10:59 p.m., José Luis Vergara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106283/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2012, 10:59 p.m.)
> 
> 
> Review request for Calligra, Boudewijn Rempt, Inge Wallin, C. Boemann, and Sven Langkamp.
> 
> 
> Description
> -------
> 
> Blob tool is the name for a vector brush that creates a broad stroke that fuses with itself and with other shapes that have the same styling, thus helping to create more organic-looking vector images.
> This patch implements a very basic version of this tool, missing the ability to fuse shapes with other shapes, which I am postponing until we fix bug 297623 (see thread http://mail.kde.org/pipermail/calligra-devel/2012-August/006633.html ).
> Further details and a link to a video in blog  http://pentalis.org/kritablog/?p=315
> 
> Note: some dependencies (like KarbonCurveFit) need to be moved, I will post a separate review for that, because I need to discuss what directory it belongs to.
> 
> I need an easy way to make clear I commit my code in either license, LGPL, GPL, or anything we need for it to fit well in our project; it's not easy to convey since files accumulate more contributors the more time passes by. Suggestions appreciated.
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt 526499f 
>   plugins/vectortools/CMakeLists.txt PRE-CREATION 
>   plugins/vectortools/KoBlobTool.h PRE-CREATION 
>   plugins/vectortools/KoBlobTool.cpp PRE-CREATION 
>   plugins/vectortools/KoBlobToolFactory.h PRE-CREATION 
>   plugins/vectortools/KoBlobToolFactory.cpp PRE-CREATION 
>   plugins/vectortools/KoVectorToolsPlugin.h PRE-CREATION 
>   plugins/vectortools/KoVectorToolsPlugin.cpp PRE-CREATION 
>   plugins/vectortools/calligravectortools.desktop PRE-CREATION 
>   plugins/vectortools/hi22-action-blob-tool.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106283/diff/
> 
> 
> Testing
> -------
> 
> Tested compilation, loading in applications Karbon and Krita, and basic functioning of the tool. It works (incompletely) as intended for a small group of use cases. Also tested speed, it needs to be faster, but is usable.
> 
> 
> Thanks,
> 
> José Luis Vergara
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120901/79d710f9/attachment.htm>