Review Request: Make it possible to disable db drivers even if the libs are present and found

Commit Hook null at kde.org
Sat Sep 1 10:21:31 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106152/#review18370
-----------------------------------------------------------


This review has been submitted with commit e4738ac78544add18f6e03210bcea01138028e59 by Andreas K. Huettel (dilfridge) to branch kexi-features-staniek.

- Commit Hook


On Aug. 23, 2012, 9:37 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106152/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2012, 9:37 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> Make it possible to disable db drivers even if the libs are present and found
> 
> + renamed drivers/mySQL to drivers/mysql to have single BUILD_mysql config flag (by jstaniek)
> 
> 
> This addresses bug 305683.
>     http://bugs.kde.org/show_bug.cgi?id=305683
> 
> 
> Diffs
> -----
> 
>   kexi/kexidb/drivers/CMakeLists.txt 917509d 
>   kexi/kexidb/drivers/mySQL/CMakeLists.txt 86668a2 
>   kexi/kexidb/drivers/mySQL/kexidb_mysqldriver.desktop 8a50263 
>   kexi/kexidb/drivers/mySQL/mysqlconnection.h b633b9e 
>   kexi/kexidb/drivers/mySQL/mysqlconnection.cpp 3ab922e 
>   kexi/kexidb/drivers/mySQL/mysqlconnection_p.h c24c393 
>   kexi/kexidb/drivers/mySQL/mysqlconnection_p.cpp 36c8cc1 
>   kexi/kexidb/drivers/mySQL/mysqlcursor.h 5284f94 
>   kexi/kexidb/drivers/mySQL/mysqlcursor.cpp fd258cf 
>   kexi/kexidb/drivers/mySQL/mysqldriver.h 9eb1813 
>   kexi/kexidb/drivers/mySQL/mysqldriver.cpp 06f0641 
>   kexi/kexidb/drivers/mySQL/mysqldriver_global.h 1e8b3ff 
>   kexi/kexidb/drivers/mySQL/mysqlkeywords.cpp 79fae74 
>   kexi/kexidb/drivers/mySQL/mysqlpreparedstatement.h d174cfd 
>   kexi/kexidb/drivers/mySQL/mysqlpreparedstatement.cpp 0dbd812 
>   kexi/kexidb/drivers/mysql/CMakeLists.txt PRE-CREATION 
>   kexi/kexidb/drivers/mysql/kexidb_mysqldriver.desktop PRE-CREATION 
>   kexi/kexidb/drivers/mysql/mysqlconnection.h PRE-CREATION 
>   kexi/kexidb/drivers/mysql/mysqlconnection.cpp PRE-CREATION 
>   kexi/kexidb/drivers/mysql/mysqlconnection_p.h PRE-CREATION 
>   kexi/kexidb/drivers/mysql/mysqlconnection_p.cpp PRE-CREATION 
>   kexi/kexidb/drivers/mysql/mysqlcursor.h PRE-CREATION 
>   kexi/kexidb/drivers/mysql/mysqlcursor.cpp PRE-CREATION 
>   kexi/kexidb/drivers/mysql/mysqldriver.h PRE-CREATION 
>   kexi/kexidb/drivers/mysql/mysqldriver.cpp PRE-CREATION 
>   kexi/kexidb/drivers/mysql/mysqldriver_global.h PRE-CREATION 
>   kexi/kexidb/drivers/mysql/mysqlkeywords.cpp PRE-CREATION 
>   kexi/kexidb/drivers/mysql/mysqlpreparedstatement.h PRE-CREATION 
>   kexi/kexidb/drivers/mysql/mysqlpreparedstatement.cpp PRE-CREATION 
>   kexi/migration/mysql/mysqlmigrate.h 1b10a76 
>   kexi/migration/mysql/mysqlmigrate.cpp b3a658f 
>   kexi/tools/sql_keywords/Makefile 353b5b1 
> 
> Diff: http://git.reviewboard.kde.org/r/106152/diff/
> 
> 
> Testing
> -------
> 
> Tested by building - disabling works
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120901/808086c6/attachment.htm>


More information about the calligra-devel mailing list