Review Request: Fix the layer docker of karbon to work again after part/document split
Commit Hook
null at kde.org
Sat Sep 1 05:52:51 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106210/#review18358
-----------------------------------------------------------
This review has been submitted with commit bbfda532bc81307c56aa91faa91cd5f3357194b2 by Thorsten Zachmann to branch master.
- Commit Hook
On Aug. 26, 2012, 7:05 a.m., Thorsten Zachmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106210/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2012, 7:05 a.m.)
>
>
> Review request for Calligra and Jan Hambrecht.
>
>
> Description
> -------
>
> When the part/document split happened the layer docker got broken as not all was ported correctly.
>
> This patch uses the KoCanvasObserverBase to see that the document has changed and acts on that instead of using the karbon part.
>
>
> This addresses bug 305259.
> http://bugs.kde.org/show_bug.cgi?id=305259
>
>
> Diffs
> -----
>
> karbon/ui/KarbonView.cpp 620626e
> karbon/ui/dockers/KarbonLayerDocker.h df349d4
> karbon/ui/dockers/KarbonLayerDocker.cpp 6831bf9
> karbon/ui/widgets/KarbonCanvas.h 790fcdb
> karbon/ui/widgets/KarbonCanvas.cpp 6371f5a
>
> Diff: http://git.reviewboard.kde.org/r/106210/diff/
>
>
> Testing
> -------
>
> Opened a document with layers. The layers are displayed again and it is possible to manipulate them.
>
>
> Thanks,
>
> Thorsten Zachmann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120901/8eddc29b/attachment.htm>
More information about the calligra-devel
mailing list