Review Request: Fix for Text Editor stripping out rich text formatting in Kexi Forms

[Dimitrios Tanis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107120/#review21264
-----------------------------------------------------------



kexi/plugins/forms/widgets/kexidbtextedit.cpp
<http://git.reviewboard.kde.org/r/107120/#comment16586>

    Why don't we make textEdit, rich text agnostic for max length? e.g.
    
    Replace lines 139-144 with:
    t = toPlainText();
    
    That way max length is presumed to be for the VISIBLE text (aka plainText) and not include markup when we have a rich text (that the user doesn't even see).
    


- Dimitrios Tanis


On Oct. 30, 2012, 12:12 a.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107120/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2012, 12:12 a.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Dimitrios Tanis, Radosław Wicik, and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> Fix for Text Editor stripping out rich text formatting in Kexi Forms.
> 
> For 2.5.4 as well.
> 
> 
> This addresses bug 309174.
>     http://bugs.kde.org/show_bug.cgi?id=309174
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/forms/widgets/kexidbtextedit.cpp 2216e0c78d686ae5dbe40b7979b1ee7a62f6f789 
> 
> Diff: http://git.reviewboard.kde.org/r/107120/diff/
> 
> 
> Testing
> -------
> 
> Properly saves and displays text when rich text property is on or off
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121031/35a39471/attachment.htm>