Review Request: Introduce roundtripping for annotations

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107088/#review21174
-----------------------------------------------------------


Fixed all of boemann's issues. Most of friedrich's remain. Those issues are going to be handled by Gopalakrishna since he is going to work on the UI.


libs/kotext/KoAnnotation.h
<http://git.reviewboard.kde.org/r/107088/#comment16573>

    I don't understand the purpose of the parameter. If you fix it as you want it in KoBookmark, I will fix it here.



libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/107088/#comment16574>

    Actually there is no such thing as annotation-start.  You are thinking of bookmark and bookmark-start.



libs/widgets/CMakeLists.txt
<http://git.reviewboard.kde.org/r/107088/#comment16575>

    Ok, fixed but you have quite a lot of them yourself in your code. ;)
    
    The only reason anybody notices them to begin with is because the author of the reviewboard didn't like them and therefore marks them with red.



libs/widgets/KoAnnotationBalloon.cpp
<http://git.reviewboard.kde.org/r/107088/#comment16576>

    Teach me how, o master. :)
    
    This isn't code I wrote, btw.  It's even disabled now. But of course we should do that,yes.



libs/widgets/KoAnnotationSideBar.cpp
<http://git.reviewboard.kde.org/r/107088/#comment16577>

    No, the style sucks.  Luckily we will through away all of this code anyway since the actual UI that it creates is horrible.


- Inge Wallin


On Oct. 28, 2012, 2:47 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107088/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2012, 2:47 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> I really wanted to have annotations for 2.6. But this patch at least brings loading, storing and saving of annotations even if they cannot yet be be created or edited or even shown.  
> 
> The patch contained some parts that had to do with the view in Words but I disabled that. It's easy to remove if necessary.
> 
> For reasons you can read on the mailing list I would really like to get this patch into 2.6.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/CMakeLists.txt 28faa22 
>   libs/kotext/KoAnnotation.h PRE-CREATION 
>   libs/kotext/KoAnnotation.cpp PRE-CREATION 
>   libs/kotext/KoAnnotationManager.h PRE-CREATION 
>   libs/kotext/KoAnnotationManager.cpp PRE-CREATION 
>   libs/kotext/KoTextInlineRdf.h 91dbccd 
>   libs/kotext/KoTextInlineRdf.cpp 1017cf4 
>   libs/kotext/KoTextRangeManager.h fc6fb95 
>   libs/kotext/KoTextRangeManager.cpp 5417be8 
>   libs/kotext/opendocument/KoTextLoader.cpp 5cf9543 
>   libs/widgets/CMakeLists.txt 61df2d6 
>   libs/widgets/KoAnnotationBalloon.h PRE-CREATION 
>   libs/widgets/KoAnnotationBalloon.cpp PRE-CREATION 
>   libs/widgets/KoAnnotationSideBar.h PRE-CREATION 
>   libs/widgets/KoAnnotationSideBar.cpp PRE-CREATION 
>   libs/widgets/KoBalloon.h PRE-CREATION 
>   libs/widgets/KoBalloon.cpp PRE-CREATION 
>   words/part/KWCanvas.cpp 08060d2 
>   words/part/KWCanvasBase.cpp e74835e 
>   words/part/KWCanvasItem.cpp dd90755 
>   words/part/KWView.cpp b1004ed 
>   words/part/tests/CMakeLists.txt 9fa7787 
> 
> Diff: http://git.reviewboard.kde.org/r/107088/diff/
> 
> 
> Testing
> -------
> 
> Test file created by LibreOffice.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121030/53da7b72/attachment.htm>