Review Request: FindEigen2.cmake: use pkgconfig hints
Boudewijn Rempt
boud at valdyas.org
Sat Oct 27 10:09:32 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107027/#review20984
-----------------------------------------------------------
Ship it!
Works on opensuse as well, please push.
cmake/modules/FindEigen2.cmake
<http://git.reviewboard.kde.org/r/107027/#comment16493>
Whitespace error.
- Boudewijn Rempt
On Oct. 24, 2012, 7:25 p.m., Rex Dieter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107027/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2012, 7:25 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Use pkgconfig hints in FindEigen2.cmake, else autodetection fails on fedora, due to eigen2 build using different values of INCLUDE_INSTALL_DIR cmake macro
>
>
> Diffs
> -----
>
> cmake/modules/FindEigen2.cmake 74e183e
>
> Diff: http://git.reviewboard.kde.org/r/107027/diff/
>
>
> Testing
> -------
>
> confirmed functional on fedora 18 + calligra-2.5.90 build.
>
>
> Thanks,
>
> Rex Dieter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121027/64fb3a23/attachment.htm>
More information about the calligra-devel
mailing list