Review Request: Fixing the text search navigation in calligra active spreadsheet

[Shantanu Tushar Jha]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107052/#review20968
-----------------------------------------------------------

Ship it!


Ship It!

- Shantanu Tushar Jha


On Oct. 26, 2012, 11:43 a.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107052/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2012, 11:43 a.m.)
> 
> 
> Review request for Calligra and Shantanu Tushar Jha.
> 
> 
> Description
> -------
> 
> The text search navigation in calligra active spreadsheet had following issues:
> 
> 1) when user searches for text in a sheet and moves to another, the search doesn't lands up in a
>    proper position in next/previous sheet.
> 
> 2) There were issues with the sheet navigation with respect to the text search.
> 
> These issues are fixed using this patch.
> 
> 
> Diffs
> -----
> 
>   active/src/CASpreadsheetHandler.cpp 69a59db 
> 
> Diff: http://git.reviewboard.kde.org/r/107052/diff/
> 
> 
> Testing
> -------
> 
> This is tested using a sample spreadsheet.
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121026/ba4c1eec/attachment.htm>