Review Request: Adding 18n support for calligra active

[Yuri Chornoivan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107064/#review20963
-----------------------------------------------------------


Do not know if it matters, but shouldn't there be some changes to extract script (Messages.sh)? Does Calligra Active really loads some translation catalog?


active/qml/PresentationTopToolbar.qml
<http://git.reviewboard.kde.org/r/107064/#comment16487>

    Should be i18n("Slide %1 of %2", root.documentController.documentHandler.currentSlideNumber, root.documentController.documentHandler.totalNumberOfSlides)



active/qml/TextDocumentCenterOverlay.qml
<http://git.reviewboard.kde.org/r/107064/#comment16488>

    Should be i18n("Page %1", (index + 1))


- Yuri Chornoivan


On Oct. 26, 2012, 6 p.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107064/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2012, 6 p.m.)
> 
> 
> Review request for Calligra and Shantanu Tushar Jha.
> 
> 
> Description
> -------
> 
> Adding i18n support for the calligra active.
> 
> 
> Diffs
> -----
> 
>   active/qml/PresentationFindToolbar.qml 33b6aeb 
>   active/qml/PresentationTopToolbar.qml bf06418 
>   active/qml/SpreadsheetFindToolbar.qml fb76f87 
>   active/qml/TextDocumentCenterOverlay.qml 2a1ee93 
>   active/qml/TextDocumentFindToolbar.qml 8f0437f 
> 
> Diff: http://git.reviewboard.kde.org/r/107064/diff/
> 
> 
> Testing
> -------
> 
> Tested with sample doc, presentation and spreadsheet.
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121026/4373b1d5/attachment.htm>