Review Request: Move the theme manager from Krita to KoMainWindow
Boudewijn Rempt
boud at valdyas.org
Tue Oct 23 08:28:09 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107002/
-----------------------------------------------------------
Review request for Calligra.
Description
-------
This makes per-app theming available to all Calligra applications, make sure the initial dialog is themed as well and finally avoid a nasty problem with some styles where the menubar and toolbar aren't themed if they aren't created after the theme is applied
The theme manager itself comes from Digikam and I intentionally didn't change any code there (except to disable starting the color kcm on windows) so it remains easy to use new versions. When frameworks 5 ends the feature freeze for the kde libraries, we should propose this as a shared component.
Diffs
-----
krita/ui/CMakeLists.txt a72e620
krita/ui/kis_view2.cpp 738ed88
krita/ui/thememanager.h 3d4680c
krita/ui/thememanager.cpp 2765f7b
krita/ui/thememanager.rc 9a66017
libs/main/CMakeLists.txt 2ad52c9
libs/main/KoMainWindow.cpp 67c1aa2
libs/main/calligra_shell.rc b393dd6
libs/main/thememanager.h PRE-CREATION
libs/main/thememanager.cpp PRE-CREATION
libs/main/thememanager.rc PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/107002/diff/
Testing
-------
Screenshots
-----------
Words, themed.
http://git.reviewboard.kde.org/r/107002/s/797/
Thanks,
Boudewijn Rempt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121023/e22dc55e/attachment.htm>
More information about the calligra-devel
mailing list