Review Request: Introduce KoTextRange instead of inline characters

Inge Wallin inge at lysator.liu.se
Mon Oct 22 14:08:18 BST 2012


On Monday, October 22, 2012 11:38:22 C. Boemann wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106983/
> -----------------------------------------------------------
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Using inline characters for things like anchors, bookmarks, annotations,
> softbreaks means that the inlinecharacter show up like invisible
> characters.
> 
> This is very undesirably, and prone to all kinds of bugs. Qt has a clas
> that already handles this mostly correctly: QTextCursor. We just need to
> put our own handling on top.
> 
> This up our requirement to qt 4.7 because we need a special feature, and
> there is even a bug in that feature i had to work around for the time
> being.
> 
> I suspect lots of changes is needed before it's mergable, and expect a
> thorough review by interested parties

I did a review but the review board wouldn't accept it. Instead I got a 
"internal server error" message.  So I took the webpage as it was just before 
publishing it and sent it as a mail to boemann.  If anybody else wants it I 
can send it to them too.  But there wasn't anything revolutionary in it.




More information about the calligra-devel mailing list