Review Request: "Rename" action in Project Navigator can be also used to change object's caption

Commit Hook null at kde.org
Sun Oct 21 19:39:59 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106943/#review20639
-----------------------------------------------------------


This review has been submitted with commit 8bcbf0202be595ce3e324c13cbe590b2863c49d2 by Jaroslaw Staniek to branch master.

- Commit Hook


On Oct. 18, 2012, 11:50 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106943/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2012, 11:50 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> "Rename" action in Project Navigator can be also used to change object's caption
> 
> Moreover:
> * Before renaming any object, close window containing it
> * Renaming object updates its position on sorted list in Project Navigator
> 
> 
> This addresses bug 308617.
>     http://bugs.kde.org/show_bug.cgi?id=308617
> 
> 
> Diffs
> -----
> 
>   kexi/core/kexiproject.cpp 3489e3defd3660cb432474d0f2547c926d51fa5c 
>   kexi/core/kexipart.h c030f1a1abbc1b052425727e28852ce18940d44c 
>   kexi/core/kexipart.cpp 11c3b157595d351fb01fd927c2c5c174e4578474 
>   kexi/core/kexiproject.h b0f87adcc42bafc1f5f3e640d0cb34295d502da8 
>   kexi/main/KexiMainWindow.h 347b75839839139b6165d3c63caa3ae6f61a260b 
>   kexi/main/KexiMainWindow.cpp 7542485eb6c0c313c61b9522b3273b773a8467c8 
>   kexi/plugins/queries/kexiquerypart.h 5e0691267341065ea9880d841ed490b3edb20c32 
>   kexi/plugins/queries/kexiquerypart.cpp cf6fbe91457856eb497bc7b5ef5f498827fde5bc 
>   kexi/plugins/tables/kexitablepart.h 2e1ec119d492a9a16ca71a190d9906f3adbd40c6 
>   kexi/plugins/tables/kexitablepart.cpp a7db3a16b8bbe1f661f085e9b33b5eb59cd420f2 
>   kexi/widget/KexiNameDialog.cpp 199cd0541101731a0fd1d52325dbf8ff1df0fd61 
>   kexi/widget/KexiNameWidget.h 8ba88a478d1f42a1b224fee3f0303c3a1cedda3d 
>   kexi/widget/KexiNameWidget.cpp 5fcabe813dce8eea36c65f588119ebc038e97849 
>   kexi/widget/navigator/KexiProjectModel.h 56ecaa47fbc3270471ad1086697b83d26882e961 
>   kexi/widget/navigator/KexiProjectModel.cpp 05f3689ecc13e59bcd07da71b745539e2cbea055 
>   kexi/widget/navigator/KexiProjectModelItem.cpp 328538ad51ff3d038a04cabdb8e694834e6b2d55 
>   kexi/widget/navigator/KexiProjectNavigator.h 46211bb7b716a92fec76fffd742d8de40267f2c6 
>   kexi/widget/navigator/KexiProjectNavigator.cpp 788a14dabc9d7216a8ea8518c246751cfdf4fd8f 
> 
> Diff: http://git.reviewboard.kde.org/r/106943/diff/
> 
> 
> Testing
> -------
> 
> Properly displays dialog and updates item data.
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121021/346fba57/attachment.htm>


More information about the calligra-devel mailing list