Review Request: Adding text search feature for calligra active spreadsheet

Shantanu Tushar Jha shaan7in at gmail.com
Fri Oct 19 17:01:21 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106948/#review20576
-----------------------------------------------------------

Ship it!


Looks nice! Just the small change and ship it


active/src/CASpreadsheetHandler.h
<http://git.reviewboard.kde.org/r/106948/#comment16242>

    cosmetic: move the enum section to just after public:


- Shantanu Tushar Jha


On Oct. 19, 2012, 1:28 p.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106948/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2012, 1:28 p.m.)
> 
> 
> Review request for Calligra and Shantanu Tushar Jha.
> 
> 
> Description
> -------
> 
> Adding text search feature to calligra active Spreadsheet.
> 
> 
> Diffs
> -----
> 
>   active/qml/SpreadsheetFindToolbar.qml PRE-CREATION 
>   active/src/CAPresentationHandler.cpp 131bc19 
>   active/src/CASpreadsheetHandler.h 2efa9f1 
>   active/src/CASpreadsheetHandler.cpp 1d68564 
> 
> Diff: http://git.reviewboard.kde.org/r/106948/diff/
> 
> 
> Testing
> -------
> 
> Testing was done using a sample spreadsheet.
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121019/0c5ee6f9/attachment.htm>


More information about the calligra-devel mailing list