Review Request: Roundtrip master documents

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106942/#review20564
-----------------------------------------------------------

Ship it!


Sounds safe enough


words/part/KWOdfLoader.cpp
<http://git.reviewboard.kde.org/r/106942/#comment16237>

    spaces


- C. Boemann


On Oct. 18, 2012, 10:58 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106942/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2012, 10:58 a.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> It seems that the only differences between a master document and a normal ODT are:
>  - An attribute text:global on the office:text tag (deprecated in ODF 1.2 but valid in 1.0 and 1.1)
>  - A slightly different mime type
> 
> This patch adds support for roundtripping a master document even if it isn't handled correctly by Words yet.
> 
> Note that for LibreOffice to read it correctly, Friedrich's patch to KoDocument that was just put up for review is also needed.
> 
> 
> Diffs
> -----
> 
>   words/part/KWDocument.h e0e4dd1 
>   words/part/KWDocument.cpp 6a6e7ae 
>   words/part/KWOdfLoader.cpp 215b332 
>   words/part/KWOdfWriter.cpp 6196dcc 
>   words/part/words.desktop e734a18 
>   words/part/wordspart.desktop c000807 
> 
> Diff: http://git.reviewboard.kde.org/r/106942/diff/
> 
> 
> Testing
> -------
> 
> Testing with output from LO
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121018/ca5e09c1/attachment.htm>