Review Request: Improve tristate class

[Adam Pigg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106828/#review20276
-----------------------------------------------------------

Ship it!


Ship It!

- Adam Pigg


On Oct. 13, 2012, 3:37 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106828/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2012, 3:37 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> Improve tristate class
> 
> General
> *tristate class:
> **comparison to 'cancelled' value fixed
> **more methods made inline
> **added more assignment and comparison operators
> **added qDebug() operators
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMainWindow.cpp ebef21a81779ae98ae21667511b2ff7464ee43ca 
>   libs/db/connection.cpp 6ceb8889412a68d70a2c208abe9fd71aeee042b3 
>   libs/db/tristate.h 9502747bab278cad9ac8f5ae7107ed35178f28d4 
> 
> Diff: http://git.reviewboard.kde.org/r/106828/diff/
> 
> 
> Testing
> -------
> 
> properly runs with many combinations in Kexi
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121013/1a97e4c8/attachment.htm>