Review Request: KexiDB: LookupFieldSchema: improve debug and API, add copy ctor

[Adam Pigg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106752/#review20257
-----------------------------------------------------------

Ship it!


Ship It!

- Adam Pigg


On Oct. 6, 2012, 11:20 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106752/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2012, 11:20 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> KexiDB: LookupFieldSchema:
> 
> - improve debug and API
> - add copy ctor (so "alter table design" code can use it to properly recreate table)
> - add support properties get/set by name
> - improve support for get/set of fields by name
> - field: width property renamed to defaultWidth
> 
> 
> Diffs
> -----
> 
>   kexi/kexidb/alter.h 9d62561826ff3fdc196750e554f5e56d82ed7d03 
>   kexi/kexidb/alter.cpp 4425d44e721acb63b2c2536b8e69e78e0a8a0ab4 
>   kexi/plugins/tables/kexitabledesignerview.cpp 79284f1a3b2a39681dc84f3e6be9194aeeaa9215 
>   libs/db/connection.cpp 1f85b616674debdc4d436e96300e25e4e98e450d 
>   libs/db/field.h 66fa7997ab698c4130641c70263985fe177d06b4 
>   libs/db/lookupfieldschema.h 460567c15ba4d7642b5f4ccde112ae62960de97d 
>   libs/db/lookupfieldschema.cpp e326254f3e60dfbd74fea5d8e2276d784d09db43 
>   libs/db/tableschema.h 3a1084a8ad4d370a044b5c7e4b09494155df2cfa 
>   libs/db/tableschema.cpp 4e5951687a40bfebc134bfc6711a0a9314515798 
>   libs/db/utils.h 3d8f09871fcf1bab1994b5a2fab3b2847407d6ac 
>   libs/db/utils.cpp 32b7f452b1a0ce2e932962c53231cf9d9e83fe27 
> 
> Diff: http://git.reviewboard.kde.org/r/106752/diff/
> 
> 
> Testing
> -------
> 
> works with new alter table code
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121013/86f599d6/attachment.htm>