Review Request: Do not build kexi if calligradb is not build

Friedrich W. H. Kossebau kossebau at kde.org
Fri Oct 12 13:23:20 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106808/#review20223
-----------------------------------------------------------

Ship it!


Otherwise looks fine I think, so with the else fixed I would ship it.


CMakeLists.txt
<http://git.reviewboard.kde.org/r/106808/#comment15972>

    else, not elseif
    
    At least with elseif the whole logic failed for me, cmake version 2.8.8.


- Friedrich W. H. Kossebau


On Oct. 11, 2012, 9:35 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106808/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 9:35 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> Do not build kexi if calligradb is not build
> 
> Similar check as Friedrich's (https://git.reviewboard.kde.org/r/106805/) but use SHOULD_BUILD_CALLIGRADB so 'HAVE_ICU AND HAVE_SQLITE' check needs to be performed only once.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f63bc07ae610352db3ac06f5c98717f564ffe120 
>   libs/CMakeLists.txt 45420819c9d70b387ac4d5543a628f82781c0aca 
> 
> Diff: http://git.reviewboard.kde.org/r/106808/diff/
> 
> 
> Testing
> -------
> 
> configures OK
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121012/72818aab/attachment.htm>


More information about the calligra-devel mailing list