Review Request: Do not build kexi if calligradb is not build
Friedrich W. H. Kossebau
kossebau at kde.org
Fri Oct 12 13:14:24 BST 2012
> On Oct. 11, 2012, 9:36 p.m., Jarosław Staniek wrote:
> > CMakeLists.txt, line 123
> > <http://git.reviewboard.kde.org/r/106805/diff/1/?file=89212#file89212line123>
> >
> > why IHAVEPATCHEDQT?
accidently slipped in, please ignore
On Oct. 11, 2012, 9:36 p.m., Friedrich W. H. Kossebau wrote:
> > Please rather look at the patch at https://git.reviewboard.kde.org/r/106808/
Your solution looks much cleaner, so discarding this one.
- Friedrich W. H.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106805/#review20207
-----------------------------------------------------------
On Oct. 11, 2012, 7:58 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106805/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2012, 7:58 p.m.)
>
>
> Review request for Calligra and Jarosław Staniek.
>
>
> Description
> -------
>
> kexi seems to rely hard on calligradb.
> calligradb needs icu and sqlite, but these are listed as optional. and if not installed, build of kexi will fail, as calligradb is not built.
>
> Attached patch blocks the build if any of these two deps is not present.
>
> piggz: "seems sane, check with jstaniek too"
>
>
> Diffs
> -----
>
> CMakeLists.txt f63bc07
>
> Diff: http://git.reviewboard.kde.org/r/106805/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121012/4ed376ee/attachment.htm>
More information about the calligra-devel
mailing list