Review Request: fix bad offset of cursor markers in rulers if document is smaller than canvas (Stage/Flow)
Commit Hook
null at kde.org
Sun Oct 7 15:49:29 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106405/#review20036
-----------------------------------------------------------
This review has been submitted with commit b9977978411d9b432a779ff9017b69d1849ada82 by Friedrich W. H. Kossebau to branch calligra/2.5.
- Commit Hook
On Sept. 9, 2012, 5:03 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106405/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2012, 5:03 p.m.)
>
>
> Review request for Calligra, Yue Liu and Thorsten Zachmann.
>
>
> Description
> -------
>
> Attached patch aligns the code of KoPAView::updateMousePosition(...) with KarbonView::mousePositionChanged(...).
> Seems Words does not have this problem, due to a different canvas behaviour? Did not investigate.
>
> Krita has the same problem, but the same fix for KisZoomManager::mousePositionChanged(...) does not help, as KisCanvas2::documentOrigin() is out-of-function ATM. See reply to "Need review and testing for 'zoom-pan-testing-kazakov' branch" on mailinglist calligra-devel.
>
> No idea if a backport is needed, have not tested and this bug may only have appeared with the recent infinite canvas addition.
> Anyone with a 2.5 can confirm the bug?
>
>
> Diffs
> -----
>
> libs/kopageapp/KoPAView.cpp d88eece
>
> Diff: http://git.reviewboard.kde.org/r/106405/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121007/f91380c4/attachment.htm>
More information about the calligra-devel
mailing list