Review Request: Fix the lowercase fix and db import

[Dimitrios Tanis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106726/#review19941
-----------------------------------------------------------

Ship it!


Ship It!

- Dimitrios Tanis


On Oct. 4, 2012, 9:32 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106726/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 9:32 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> Fix the lowercase fix and db import
> 
> KexiDB
> *A fix for the lowercase fix: keep table names in original format but compare them in case-insensitive way when needed
> **This way importing from databases with tables upper-case characters works
> 
> Migration
> *Fix invalid SQL generation for database import
> *Fix importing from databases with tables upper-case characters
> 
> Details: premature converting table names to lower-case leads to issues when user had upper-case letters in names. Kexi now prevents uppercase letters via the GUI only, without any special cases while importing. This will also help in future expansion to 'attach/link to a non-kexi DBs' feature.
> 
> 
> This addresses bugs 306523 and 307479.
>     http://bugs.kde.org/show_bug.cgi?id=306523
>     http://bugs.kde.org/show_bug.cgi?id=307479
> 
> 
> Diffs
> -----
> 
>   kexi/core/kexiproject.cpp 1a7b962749db910d5c04d4690b352fb5b9baba4e 
>   kexi/migration/keximigrate.cpp 75b84d59efa21ab84da9ec77971d4285fb61752a 
>   kexi/migration/mysql/mysqlmigrate.cpp 0fb0d47b914fc4d5ef802c583f83de0aa784c7a0 
>   libs/db/connection.cpp d36def0c1b66440c79fa617bc185b47cf2d67d06 
>   libs/db/expression.cpp 77f4fa93b4fd8bfc49ffdb12e8b205b5d0b34a3c 
>   libs/db/tableschema.cpp 8bf2eeca75c792b9a78c626dd4aeb6893784413b 
> 
> Diff: http://git.reviewboard.kde.org/r/106726/diff/
> 
> 
> Testing
> -------
> 
> importing and usual db operations tested
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121004/97732cce/attachment.htm>