Review Request: Separate the so called style docker (stroke/fill docker) into a docker and a widget

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106633/#review19932
-----------------------------------------------------------


This review has been submitted with commit 50e2cae7d93f0e21f0043cd87f7a08a516809cee by Inge Wallin to branch master.

- Commit Hook


On Sept. 29, 2012, 6 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106633/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2012, 6 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch fulfills a very old wish of ours, namely the separation of the stroke/fill docker into a widget and an embedding docker. This makes the stroke/fill widget reusable in other places, e.g. a style manager for graphic styles.
> 
> I have tried to make the user experience exactly the same as for the old version even though there are lots of misfeatures with it.  Improving the user experience will come as future patches, and I don't want to do that without discussing it with other people.
> 
> 
> Diffs
> -----
> 
>   plugins/dockers/CMakeLists.txt c9b4f44 
>   plugins/dockers/styledocker/StrokeFillWidget.h PRE-CREATION 
>   plugins/dockers/styledocker/StrokeFillWidget.cpp PRE-CREATION 
>   plugins/dockers/styledocker/StyleDocker.h b0301e6 
>   plugins/dockers/styledocker/StyleDocker.cpp 376ffef 
> 
> Diff: http://git.reviewboard.kde.org/r/106633/diff/
> 
> 
> Testing
> -------
> 
> Extensive manual testing.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121004/54ee6024/attachment.htm>