Review Request: Activities support for Calligra Suite
Jarosław Staniek
staniek at kde.org
Wed Oct 3 20:46:34 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106714/#review19850
-----------------------------------------------------------
Cool, just a note, Kexi is not document-oriented app so it doesn't use this common class; additional patch would be welcome in the future. I can help with some hints.
libs/main/KoMainWindow.cpp
<http://git.reviewboard.kde.org/r/106714/#comment15764>
We tend to start #ifdef at the 0th column.
libs/main/KoMainWindow.cpp
<http://git.reviewboard.kde.org/r/106714/#comment15765>
same here
- Jarosław Staniek
On Oct. 3, 2012, 5:12 p.m., Ivan Čukić wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106714/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2012, 5:12 p.m.)
>
>
> Review request for Calligra and Plasma.
>
>
> Description
> -------
>
> Calligra applications report the open/close document events to activity manager daemon.
>
> Side-effect - support for Share-Like-Connect applet.
>
>
> Diffs
> -----
>
> CMakeLists.txt 04d35c3
> KoConfig.h.cmake 02f40c3
> libs/main/CMakeLists.txt 3653de2
> libs/main/KoMainWindow.cpp 8eb8dff
>
> Diff: http://git.reviewboard.kde.org/r/106714/diff/
>
>
> Testing
> -------
>
> Tested with flow, words and krita.
>
>
> Screenshots
> -----------
>
> SLC
> http://git.reviewboard.kde.org/r/106714/s/753/
>
>
> Thanks,
>
> Ivan Čukić
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121003/b71fcf62/attachment.htm>
More information about the calligra-devel
mailing list