Review Request: Adds d-pointers to Kexi classes in kexi/core

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107515/#review22839
-----------------------------------------------------------


I have indicated general problems, please study the d-pointers technique a bit more and apply here. Please test compilation of the entire Kexi (no need to 'make clean'), and run Kexi before submitting updated patch.


kexi/core/kexidataiteminterface.h
<http://git.reviewboard.kde.org/r/107515/#comment17414>

    We need tp add  void setHasFocusableWidget(bool), otherwise subclasses cannot access the attribute, right?



kexi/core/kexidataiteminterface.h
<http://git.reviewboard.kde.org/r/107515/#comment17415>

    Please move this to the top of kexidataiteminterface.cpp. Also please implement constructor and initialize members in it.



kexi/core/kexiinternalpart.h
<http://git.reviewboard.kde.org/r/107515/#comment17416>

    Please remove inline - it's no longer inline, right?



kexi/core/kexiinternalpart.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17417>

    This cannot work, you have two definitions, here and in line 100. 
    Also please initialize the members properly.



kexi/core/kexiinternalpart.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17418>

    This cannot be allowed. Instead please use part->uniqueWidget(). Please fix all other cases like this in the whole code.



kexi/core/kexipartmanager.h
<http://git.reviewboard.kde.org/r/107515/#comment17419>

    please remove this #if 0 block



kexi/core/kexipartmanager.h
<http://git.reviewboard.kde.org/r/107515/#comment17421>

    No need to move it.



kexi/core/kexipartmanager.h
<http://git.reviewboard.kde.org/r/107515/#comment17420>

    Again, no definition here allowed.



kexi/core/kexipartmanager.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17422>

    Please just move lines 50-51.



kexi/core/kexiprojectconnectiondata.h
<http://git.reviewboard.kde.org/r/107515/#comment17423>

    Please just move, not comment out.



kexi/core/kexiprojectconnectiondata.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17424>

    Build error here...



kexi/core/kexistartupdata.h
<http://git.reviewboard.kde.org/r/107515/#comment17425>

    Not in header...



kexi/core/kexistartupdata.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17426>

    Move to Private's constructor.



kexi/core/kexistartupdata.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17427>

    Memory leak here, you miss 'delete projectData;' in ~Private()



kexi/core/kexitextmsghandler.h
<http://git.reviewboard.kde.org/r/107515/#comment17428>

    not in header...



kexi/core/kexitextmsghandler.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17429>

    crash because you did not initialize these pointers in Private's constructor


- Jarosław Staniek


On Nov. 30, 2012, 2:38 p.m., Andrey Inishev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107515/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2012, 2:38 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> Patch for kexi/core, http://www.google-melange.com/gci/task/view/google/gci2012/8009216
> 
> 
> Diffs
> -----
> 
>   kexi/core/kexidataiteminterface.h 4258451 
>   kexi/core/kexidataiteminterface.cpp a5ad759 
>   kexi/core/kexiinternalpart.h 08178ed 
>   kexi/core/kexiinternalpart.cpp 253e77d 
>   kexi/core/kexipartmanager.h 9cb2356 
>   kexi/core/kexipartmanager.cpp cf17f3a 
>   kexi/core/kexiprojectconnectiondata.h b88a1f9 
>   kexi/core/kexiprojectconnectiondata.cpp 0df2793 
>   kexi/core/kexistartupdata.h 2147465 
>   kexi/core/kexistartupdata.cpp 45fdd71 
>   kexi/core/kexitextmsghandler.h 29adc64 
>   kexi/core/kexitextmsghandler.cpp 71011c9 
> 
> Diff: http://git.reviewboard.kde.org/r/107515/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrey Inishev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121130/27866698/attachment.htm>