Review Request: Make it possible to override info from author profile via dbus/c++
Pierre Stirnweiss
pstirnweiss at googlemail.com
Wed Nov 28 16:35:11 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107486/#review22704
-----------------------------------------------------------
Ship it!
Minor point below.
libs/main/KoDocumentInfo.h
<http://git.reviewboard.kde.org/r/107486/#comment17365>
What is the difference between ActiveAuthorInfo and AuthorInfo? Perhaps a tad more verbose description.
- Pierre Stirnweiss
On Nov. 27, 2012, 12:14 p.m., C. Boemann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107486/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2012, 12:14 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> It turns out we used to have a way for dbus to set author information.
>
> This got broken by the author profile changes, so this patch fixes that, by allowing to override the information fetched from author profiles
>
> ok to backport as well?
>
>
> Diffs
> -----
>
> libs/main/KoDocumentInfo.h d98cab4
> libs/main/KoDocumentInfo.cpp 89bcdbe
>
> Diff: http://git.reviewboard.kde.org/r/107486/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> C. Boemann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121128/65552036/attachment.htm>
More information about the calligra-devel
mailing list