Review Request: Fix copy paste to include named styles

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107495/#review22682
-----------------------------------------------------------


The code looks good, I just had a couple of minor issues.  What I wonder is if this is tested with LibreOffice and/or OpenOffice.org. Do we have interoperability?


libs/kotext/KoTextDrag.cpp
<http://git.reviewboard.kde.org/r/107495/#comment17335>

    nitpick: "referred"
    (also in the function name below)



libs/kotext/styles/KoStyleManager.h
<http://git.reviewboard.kde.org/r/107495/#comment17336>

    "referred"



libs/kotext/styles/KoStyleManager.cpp
<http://git.reviewboard.kde.org/r/107495/#comment17337>

    A comment, perhaps?


- Inge Wallin


On Nov. 27, 2012, 8:43 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107495/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2012, 8:43 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch fixes copy/paste by
>  1) saving the used styles to clipboard as well
>  2) only add a style if another style named the same doesn't exist already
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoTextDrag.cpp 9f2d537 
>   libs/kotext/KoTextOdfSaveHelper.h 39107ef 
>   libs/kotext/KoTextOdfSaveHelper.cpp e01e651 
>   libs/kotext/opendocument/KoTextWriter.cpp 0d52062 
>   libs/kotext/opendocument/KoTextWriter_p.cpp 4439769 
>   libs/kotext/styles/KoStyleManager.h ae2e720 
>   libs/kotext/styles/KoStyleManager.cpp 2aa74fe 
> 
> Diff: http://git.reviewboard.kde.org/r/107495/diff/
> 
> 
> Testing
> -------
> 
> Some basic cut and paste with variations of styles applied
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121128/89e27d8d/attachment.htm>