Review Request: fixed SqlitePrepared statement

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107475/#review22604
-----------------------------------------------------------


BTW, since this is a bug fix, please also cherry-pick to calligra/2.6 and calligra/2.5

- Jarosław Staniek


On Nov. 26, 2012, 1:45 p.m., Oleg Kukharchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107475/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2012, 1:45 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.
> 
> 
> Description
> -------
> 
> sqlite3_reset should be called immediately after sqlite3_step, because it always return error when sqlite3_step return SQLITE_ERROR
> 
> in existing implementation execute() will cause an error  if previous execute() failed.
> 
> Details: http://www.sqlite.org/c3ref/reset.html
> 
> Should be fixed in Predicate as well
> 
> 
> Diffs
> -----
> 
>   libs/db/drivers/sqlite/sqlitepreparedstatement.h be81bdc984be14eb67ff6d28d50936baeaa07173 
>   libs/db/drivers/sqlite/sqlitepreparedstatement.cpp ffb751ebb1c87c32db95f48797e4c358c7b17991 
> 
> Diff: http://git.reviewboard.kde.org/r/107475/diff/
> 
> 
> Testing
> -------
> 
> tested on csv-import
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121126/d80daa4b/attachment.htm>