Review Request: fixed KexiFieldListModel

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107481/#review22594
-----------------------------------------------------------

Ship it!


good job!


kexi/widget/fields/KexiFieldListModel.cpp
<http://git.reviewboard.kde.org/r/107481/#comment17279>

    -> else if (section == 1) {



kexi/widget/fields/KexiFieldListModel.cpp
<http://git.reviewboard.kde.org/r/107481/#comment17278>

    it's good to remove this 'else' and thus return QVariant() even if orientation == Qt::Horizontal && section > 1


- Jarosław Staniek


On Nov. 26, 2012, 7:34 p.m., Oleg Kukharchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107481/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2012, 7:34 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.
> 
> 
> Description
> -------
> 
> In case when KexiFieldListOption is set to ShowDataTypes we should provide appropriate caption for a second section of the header
> 
> it may be not necessary for a list view, but useful for a table or tree view
> 
> 
> Diffs
> -----
> 
>   kexi/widget/fields/KexiFieldListModel.cpp 91ed791065a34d8a137dc84997506bdd0643b231 
> 
> Diff: http://git.reviewboard.kde.org/r/107481/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121126/82b13424/attachment.htm>