Review Request: Updating the test case for numfile in TestInformationFunctions

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107459/#review22589
-----------------------------------------------------------



libs/main/KoApplication.cpp
<http://git.reviewboard.kde.org/r/107459/#comment17272>

    I think it is much simpler to just add the document directly to a QSet<QString> instead of first filling a list and then converting it to a set.



sheets/functions/information.cpp
<http://git.reviewboard.kde.org/r/107459/#comment17273>

    This seems to be wrong. It should return the number of of documents in the vlaue and not true and false.



sheets/tests/TestInformationFunctions.cpp
<http://git.reviewboard.kde.org/r/107459/#comment17274>

    This looks wrong. The test was working  before and it should still work with the fix.


- Thorsten Zachmann


On Nov. 25, 2012, 4:44 p.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107459/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2012, 4:44 p.m.)
> 
> 
> Review request for Calligra, Arjen Hiemstra, Boudewijn Rempt, Inge Wallin, and C. Boemann.
> 
> 
> Description
> -------
> 
> This patch helps to pass the issue in the http://build.kde.org/job/calligra_master/323/testReport/(root)/TestSuite/sheets_InformationFunctions/ because of which the test case TestInformationFunctions were failing.
> 
> 
> The failure is as below:
> FAIL!  : Calligra::Sheets::TestInformationFunctions::testINFO() Compared values are not the same
>    Actual (evaluate("ISNUMBER(INFO(\"numfile\"))",z)): Boolean: FALSE
>    Expected ((z)): Boolean: TRUE
>    Loc: [/srv/jenkins/workspace/calligra_master/sheets/tests/TestInformationFunctions.cpp(338)]
> 
> 
> Diffs
> -----
> 
>   libs/main/KoApplication.h b0bcab2 
>   libs/main/KoApplication.cpp 8ac4639 
>   sheets/functions/information.cpp 5ae962d 
>   sheets/tests/TestInformationFunctions.cpp d0adc68 
> 
> Diff: http://git.reviewboard.kde.org/r/107459/diff/
> 
> 
> Testing
> -------
> 
> I had done testing on my host machine. And here is the output:
> 
> sujith at kdekiddo:/media/kdedeveloper/kde-dev/kde/build/KDE/calligra/sheets/tests$ ./TestInformationFunctions
> ********* Start testing of Calligra::Sheets::TestInformationFunctions *********
> Config: Using QTest library 4.8.4, Qt 4.8.4
> QDEBUG : Calligra::Sheets::TestInformationFunctions::initTestCase() qttest(27285)/kdecore (KSycoca) KSycocaPrivate::openDatabase: Trying to open ksycoca from "/home/sujith/.kde-unit-test/cache-kdekiddo/ksycoca4"
> PASS   : Calligra::Sheets::TestInformationFunctions::initTestCase()
> PASS   : Calligra::Sheets::TestInformationFunctions::testAREAS()
> PASS   : Calligra::Sheets::TestInformationFunctions::testCELL()
> PASS   : Calligra::Sheets::TestInformationFunctions::testCOLUMN()
> PASS   : Calligra::Sheets::TestInformationFunctions::testCOLUMNS()
> PASS   : Calligra::Sheets::TestInformationFunctions::testCOUNT()
> PASS   : Calligra::Sheets::TestInformationFunctions::testCOUNTA()
> PASS   : Calligra::Sheets::TestInformationFunctions::testCOUNTBLANK()
> PASS   : Calligra::Sheets::TestInformationFunctions::testCOUNTIF()
> PASS   : Calligra::Sheets::TestInformationFunctions::testERRORTYPE()
> PASS   : Calligra::Sheets::TestInformationFunctions::testFORMULA()
> PASS   : Calligra::Sheets::TestInformationFunctions::testINFO()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISBLANK()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISERR()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISERROR()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISEVEN()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISFORMULA()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISLOGICAL()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISNONTEXT()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISNA()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISNUMBER()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISODD()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISTEXT()
> PASS   : Calligra::Sheets::TestInformationFunctions::testISREF()
> PASS   : Calligra::Sheets::TestInformationFunctions::testMATCH()
> PASS   : Calligra::Sheets::TestInformationFunctions::testN()
> PASS   : Calligra::Sheets::TestInformationFunctions::testNA()
> PASS   : Calligra::Sheets::TestInformationFunctions::testROW()
> PASS   : Calligra::Sheets::TestInformationFunctions::testROWS()
> PASS   : Calligra::Sheets::TestInformationFunctions::testSHEET()
> PASS   : Calligra::Sheets::TestInformationFunctions::testSHEETS()
> PASS   : Calligra::Sheets::TestInformationFunctions::testTYPE()
> PASS   : Calligra::Sheets::TestInformationFunctions::testVALUE()
> PASS   : Calligra::Sheets::TestInformationFunctions::cleanupTestCase()
> Totals: 34 passed, 0 failed, 0 skipped
> ********* Finished testing of Calligra::Sheets::TestInformationFunctions *********
> sujith at kdekiddo:/media/kdedeveloper/kde-dev/kde/build/KDE/calligra/sheets/tests$
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121126/a390e294/attachment.htm>