Review Request: Sort styles according to usage in the docker's combos

[Pierre Stirnweiss]

> On Nov. 25, 2012, 9:19 p.m., C. Boemann wrote:
> > libs/kotext/styles/KoCharacterStyle.cpp, line 1965
> > <http://git.reviewboard.kde.org/r/107445/diff/1/?file=96066#file96066line1965>
> >
> >     is this used anywhere and for what?

Ah, this is a left-over from my StylesManager branch. Well, this is present in the KoParagraphStyle and will be used (actually it should already be used in the StylesManager). I'd advocate for leaving it in, but don't mind removing it from this patch (it would be re-introduced later).


> On Nov. 25, 2012, 9:19 p.m., C. Boemann wrote:
> > plugins/textshape/dialogs/StylesModel.cpp, line 531
> > <http://git.reviewboard.kde.org/r/107445/diff/1/?file=96086#file96086line531>
> >
> >     is this a correct change?

This is also a left over from my other branch. And this one I really can't remember what it was for. It has I think nothing to do with the present functionality, so I'll remove this.


- Pierre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107445/#review22533
-----------------------------------------------------------


On Nov. 24, 2012, 2:36 p.m., Pierre Stirnweiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107445/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2012, 2:36 p.m.)
> 
> 
> Review request for Calligra, Inge Wallin and C. Boemann.
> 
> 
> Description
> -------
> 
> This introduces sorting of the styles in the combos according to usage.
> This is a first step into revamping the styles handling.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoTextEditor.h 64f47bb 
>   libs/kotext/KoTextEditor_format.cpp 8985fcc 
>   libs/kotext/styles/KoCharacterStyle.h 765f49e 
>   libs/kotext/styles/KoCharacterStyle.cpp fcb20fd 
>   libs/kotext/styles/KoParagraphStyle.h 7ee1787 
>   libs/kotext/styles/KoParagraphStyle.cpp f8bffb6 
>   libs/kotext/styles/KoStyleManager.h ae2e720 
>   libs/kotext/styles/KoStyleManager.cpp 2aa74fe 
>   plugins/textshape/CMakeLists.txt 6253323 
>   plugins/textshape/TextTool.cpp 207dfd9 
>   plugins/textshape/dialogs/AbstractStylesModel.h PRE-CREATION 
>   plugins/textshape/dialogs/AbstractStylesModel.cpp PRE-CREATION 
>   plugins/textshape/dialogs/DockerStylesComboModel.h PRE-CREATION 
>   plugins/textshape/dialogs/DockerStylesComboModel.cpp PRE-CREATION 
>   plugins/textshape/dialogs/SimpleCharacterWidget.h d14007c 
>   plugins/textshape/dialogs/SimpleCharacterWidget.cpp a7feb89 
>   plugins/textshape/dialogs/SimpleParagraphWidget.h a7d7f52 
>   plugins/textshape/dialogs/SimpleParagraphWidget.cpp 6fd2f67 
>   plugins/textshape/dialogs/StylesCombo.h 484b8fc 
>   plugins/textshape/dialogs/StylesCombo.cpp a5e7172 
>   plugins/textshape/dialogs/StylesFilteredModelBase.h PRE-CREATION 
>   plugins/textshape/dialogs/StylesFilteredModelBase.cpp PRE-CREATION 
>   plugins/textshape/dialogs/StylesModel.h 7096d53 
>   plugins/textshape/dialogs/StylesModel.cpp 64767f8 
>   plugins/textshape/dialogs/ValidParentStylesProxyModel.h PRE-CREATION 
>   plugins/textshape/dialogs/ValidParentStylesProxyModel.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107445/diff/
> 
> 
> Testing
> -------
> 
> Playing around with it did not show regressions with current state of the affair. There are a couple of glitches in handling styles, but these are also present in the current build.
> 
> 
> Thanks,
> 
> Pierre Stirnweiss
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121126/99a2b741/attachment.htm>