Review Request: Move /kdgantt/ to /3rdparty/kdgantt/ and make a real dynamic library out of it.

Jarosław Staniek staniek at kde.org
Wed Nov 21 20:47:58 GMT 2012 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107410/#review22345
-----------------------------------------------------------

Ship it!


Please look at my notes, good job!


CMakeLists.txt
<http://git.reviewboard.kde.org/r/107410/#comment17154>

    Shouldn't here be added ${CMAKE_BINARY_DIR}/3rdparty/kdgantt too? Plan uses it that way.



CMakeLists.txt
<http://git.reviewboard.kde.org/r/107410/#comment17156>

    We have no plan->no kdgantt rule, now how about adding no kdgantt->no plan rule here (BUILD_kdgantt==false if kdgantt optional subdir is disabled)?
    
    if (NOT BUILD_kdgantt)
        set(SHOULD_BUILD_PLAN FALSE)
    endif (NOT BUILD_kdgantt)
    



plan/libs/ui/CMakeLists.txt
<http://git.reviewboard.kde.org/r/107410/#comment17155>

    Shouldn't line 11 and 12 be replaced by ${KDGANTT_INCLUDES} ?


- Jarosław Staniek


On Nov. 21, 2012, 7:37 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107410/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2012, 7:37 p.m.)
> 
> 
> Review request for Calligra and Dag Andersen.
> 
> 
> Description
> -------
> 
> This patch moves the kdgantt library that was previously in the top directory into a subdirectory called 3rdparty/. This was suggested in a discussion on IRC as a way to keep 3rdparty library sources collected in one place.
> 
> More importantly it also creates a real dynamically loaded library from it and discards the old method of including the sources wherever the "library" was used. This is specifically in Plan. The reason for doing this is that building Plan totally fails on Windows without this patch.
> 
> After this patch is OK'ed and merged, I will continue with KDChart which is now residing inside the chart shape but which is also used in e.g. Kexi.
> 
> Many thanks go to Ben Cooksley and Stuart McDickson for testing and difficult bugfixing. CMake is tricky :)
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt PRE-CREATION 
>   3rdparty/kdgantt/CMakeLists.txt PRE-CREATION 
>   3rdparty/kdgantt/Mainpage.dox PRE-CREATION 
>   3rdparty/kdgantt/Messages.sh PRE-CREATION 
>   3rdparty/kdgantt/docs.h PRE-CREATION 
>   3rdparty/kdgantt/kdgantt_export.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttabstractgrid.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttabstractgrid.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttabstractgrid_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttabstractrowcontroller.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttabstractrowcontroller.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraint.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraint.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraint_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraintgraphicsitem.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraintgraphicsitem.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraintmodel.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraintmodel.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraintmodel_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraintproxy.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttconstraintproxy.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttdatetimegrid.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttdatetimegrid.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttdatetimegrid_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttforwardingproxymodel.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttforwardingproxymodel.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttglobal.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttglobal.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsitem.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsitem.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsscene.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsscene.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsscene_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsview.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsview.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttgraphicsview_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttitemdelegate.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttitemdelegate.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttitemdelegate_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttlegend.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttlegend.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttlegend_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttlistviewrowcontroller.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttlistviewrowcontroller.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttlistviewrowcontroller_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttproxymodel.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttproxymodel.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttproxymodel_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttstyleoptionganttitem.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttstyleoptionganttitem.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttsummaryhandlingproxymodel.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttsummaryhandlingproxymodel.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttsummaryhandlingproxymodel_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdgantttimescalezoomdialog.h PRE-CREATION 
>   3rdparty/kdgantt/kdgantttimescalezoomdialog.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdgantttreeviewrowcontroller.h PRE-CREATION 
>   3rdparty/kdgantt/kdgantttreeviewrowcontroller.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdgantttreeviewrowcontroller_p.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttview.h PRE-CREATION 
>   3rdparty/kdgantt/kdganttview.cpp PRE-CREATION 
>   3rdparty/kdgantt/kdganttview_p.h PRE-CREATION 
>   CMakeLists.txt 3ca1f52 
>   kdgantt/CMakeLists.txt e74903f 
>   kdgantt/Mainpage.dox 4b23dfa 
>   kdgantt/Messages.sh 65aa502 
>   kdgantt/docs.h 3b5b79c 
>   kdgantt/kdgantt_export.h 468cf4b 
>   kdgantt/kdganttabstractgrid.h 5a0be55 
>   kdgantt/kdganttabstractgrid.cpp 9408af8 
>   kdgantt/kdganttabstractgrid_p.h fb80a12 
>   kdgantt/kdganttabstractrowcontroller.h a6810cc 
>   kdgantt/kdganttabstractrowcontroller.cpp b19636f 
>   kdgantt/kdganttconstraint.h fd65df8 
>   kdgantt/kdganttconstraint.cpp 4c6dab8 
>   kdgantt/kdganttconstraint_p.h 8a216a4 
>   kdgantt/kdganttconstraintgraphicsitem.h 74847bd 
>   kdgantt/kdganttconstraintgraphicsitem.cpp 50445da 
>   kdgantt/kdganttconstraintmodel.h bc1ed5c 
>   kdgantt/kdganttconstraintmodel.cpp ea6874dd 
>   kdgantt/kdganttconstraintmodel_p.h 89df082 
>   kdgantt/kdganttconstraintproxy.h 35a15d1 
>   kdgantt/kdganttconstraintproxy.cpp 25cd488 
>   kdgantt/kdganttdatetimegrid.h 4adeb06 
>   kdgantt/kdganttdatetimegrid.cpp 79c405c 
>   kdgantt/kdganttdatetimegrid_p.h 0043e79 
>   kdgantt/kdganttforwardingproxymodel.h f0a63bb 
>   kdgantt/kdganttforwardingproxymodel.cpp b38c1aa 
>   kdgantt/kdganttglobal.h bd88e3d 
>   kdgantt/kdganttglobal.cpp a76ac62 
>   kdgantt/kdganttgraphicsitem.h 0f73c82 
>   kdgantt/kdganttgraphicsitem.cpp 25103f4 
>   kdgantt/kdganttgraphicsscene.h 516cd0c 
>   kdgantt/kdganttgraphicsscene.cpp 1d6f181 
>   kdgantt/kdganttgraphicsscene_p.h e421b7f 
>   kdgantt/kdganttgraphicsview.h 1701a9b 
>   kdgantt/kdganttgraphicsview.cpp fd07889 
>   kdgantt/kdganttgraphicsview_p.h fd20baf 
>   kdgantt/kdganttitemdelegate.h daeb16d 
>   kdgantt/kdganttitemdelegate.cpp 1e08b04 
>   kdgantt/kdganttitemdelegate_p.h 87da262 
>   kdgantt/kdganttlegend.h 4ccdb4c 
>   kdgantt/kdganttlegend.cpp 3f1e089 
>   kdgantt/kdganttlegend_p.h e5dbf25 
>   kdgantt/kdganttlistviewrowcontroller.h 23c9c92 
>   kdgantt/kdganttlistviewrowcontroller.cpp 792c7c5 
>   kdgantt/kdganttlistviewrowcontroller_p.h 302814d 
>   kdgantt/kdganttproxymodel.h ce95dce 
>   kdgantt/kdganttproxymodel.cpp 0351ad0 
>   kdgantt/kdganttproxymodel_p.h d127984 
>   kdgantt/kdganttstyleoptionganttitem.h 21ecef1 
>   kdgantt/kdganttstyleoptionganttitem.cpp e1985e6 
>   kdgantt/kdganttsummaryhandlingproxymodel.h 05e0614 
>   kdgantt/kdganttsummaryhandlingproxymodel.cpp 43f5cbc 
>   kdgantt/kdganttsummaryhandlingproxymodel_p.h 0f1d7ea 
>   kdgantt/kdgantttimescalezoomdialog.h fbcef67 
>   kdgantt/kdgantttimescalezoomdialog.cpp 86fcb32 
>   kdgantt/kdgantttreeviewrowcontroller.h 0a1251e 
>   kdgantt/kdgantttreeviewrowcontroller.cpp b9b2045 
>   kdgantt/kdgantttreeviewrowcontroller_p.h c76b902 
>   kdgantt/kdganttview.h c61d47c 
>   kdgantt/kdganttview.cpp a09edf1 
>   kdgantt/kdganttview_p.h f47b57b 
>   plan/CMakeLists.txt 0d96065 
>   plan/libs/models/CMakeLists.txt 86e08ba 
>   plan/libs/ui/CMakeLists.txt e22e4dc 
>   plan/workpackage/CMakeLists.txt 1b60b99 
>   plugins/CMakeLists.txt ab8151b 
> 
> Diff: http://git.reviewboard.kde.org/r/107410/diff/
> 
> 
> Testing
> -------
> 
> Stuart has tested on Windows and I on Linux. I'd like Dag to test if Plan works for him with this patch before I merge it.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121121/39043767/attachment.htm>

More information about the calligra-devel mailing list